Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security provider metrics fix #21390

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Security provider metrics fix #21390

merged 3 commits into from
Oct 17, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 16, 2023

Description

The PR fixes bug that user traits property security_providers should be set to blockaid if user has blockaid enabled.

Manual testing steps

_1. Enable blockaid for user
_2. User identify event should have security_providers set to blockaid

Related issues

_Fixes: MetaMask/MetaMask-planning#1459

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 16, 2023
@jpuri jpuri requested a review from a team as a code owner October 16, 2023 15:47
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bschorchit bschorchit added team-confirmations-secure-ux-PR PRs from the confirmations team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Oct 16, 2023
@jpuri jpuri merged commit e8cd9c2 into develop Oct 17, 2023
9 checks passed
@jpuri jpuri deleted the security_provider_metrics_fix branch October 17, 2023 15:32
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 17, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [efaed38]
Page Load Metrics (772 ± 365 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint831199284
domContentLoaded6712883136
load781713772759365
domInteractive6712883136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 61 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona
Copy link
Contributor

seaona commented Oct 25, 2023

This PR looks good from QA. I can see how the metrics event is fired with the correct provider, every time I update the experimental settings.

metrics-provider-settings.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.5.0 Issue or pull request that will be included in release 11.5.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants