-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security provider metrics fix #21390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Oct 16, 2023
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
segun
approved these changes
Oct 16, 2023
bschorchit
added
team-confirmations-secure-ux-PR
PRs from the confirmations team
and removed
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
labels
Oct 16, 2023
blackdevelopa
approved these changes
Oct 17, 2023
digiwand
approved these changes
Oct 17, 2023
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Oct 17, 2023
metamaskbot
added
the
release-11.5.0
Issue or pull request that will be included in release 11.5.0
label
Oct 17, 2023
Builds ready [efaed38]
Page Load Metrics (772 ± 365 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This PR looks good from QA. I can see how the metrics event is fired with the correct provider, every time I update the experimental settings. metrics-provider-settings.mp4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.5.0
Issue or pull request that will be included in release 11.5.0
team-confirmations-secure-ux-PR
PRs from the confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes bug that user traits property
security_providers
should be set toblockaid
if user has blockaid enabled.Manual testing steps
_1. Enable blockaid for user
_2. User identify event should have
security_providers
set toblockaid
Related issues
_Fixes: MetaMask/MetaMask-planning#1459
Pre-merge author checklist
Pre-merge reviewer checklist