-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing truncation and alignment in the network toggle component #21370
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c698757
to
d8dedfe
Compare
…ncomponet-transaction-toggle
d8dedfe
to
8343fec
Compare
Builds ready [8343fec]
Page Load Metrics (1199 ± 384 ms)
Bundle size diffs
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #21370 +/- ##
========================================
Coverage 68.58% 68.58%
========================================
Files 1026 1026
Lines 40978 40978
Branches 10936 10936
========================================
Hits 28104 28104
Misses 12874 12874
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Verified in storybook
- Verified in extension
Description
Currently there is some truncation issues with long network names in the privacy incoming transactions section. The truncation of the text is not working which results in broken UI for longer network names
This PR adds some styles which resolve the issue as well as adding a story for the network-toggle component for easier revision and review
Manual testing steps
NetworkToggle
and check the story in small screen sizesScreenshots/Recordings
Before
before.mov
After
after.mov
Related issues
Fixes #21369
Pre-merge author checklist
Pre-merge reviewer checklist