Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] updates metamask/keyring-controller package to latest version #21367

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Oct 13, 2023

Description

Bumps @metamask/keyring-controller package to the latest 8.0.3, in order to include the latest fix in the signTransaction method. This version is part of the latest Core release 82.0.0.
Without it MMI won't work.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner October 13, 2023 09:22
@zone-live zone-live requested a review from danjm October 13, 2023 09:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added the team-mmi PRs from the MMI team label Oct 13, 2023
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/[email protected]

@zone-live
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@zone-live zone-live requested review from a team as code owners October 13, 2023 09:46
@danjm danjm added release-blocker This bug is blocking the next release release-11.4.0 Issue or pull request that will be included in release 11.4.0 labels Oct 13, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [ec5c921]
Page Load Metrics (1109 ± 438 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90163118199
domContentLoaded721531112411
load8623511109912438
domInteractive721531112411
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -28.82 KiB (-0.76%)
  • ui: 0 Bytes (0.00%)
  • common: 72.42 KiB (1.50%)

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (69316d2) 68.59% compared to head (74a9a5d) 68.59%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21367   +/-   ##
========================================
  Coverage    68.59%   68.59%           
========================================
  Files         1026     1026           
  Lines        40978    40978           
  Branches     10936    10936           
========================================
  Hits         28107    28107           
  Misses       12871    12871           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not actually an MMI-specific change?

LGTM otherwise.

@zone-live
Copy link
Contributor Author

zone-live commented Oct 13, 2023

I guess this is not actually an MMI-specific change?

LGTM otherwise.

Hi @legobeat no 👍🏼
Thank you!

@metamaskbot
Copy link
Collaborator

Builds ready [74a9a5d]
Page Load Metrics (1103 ± 437 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882101232914
domContentLoaded702061143517
load8322091103909437
domInteractive702061143517
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -28.82 KiB (-0.76%)
  • ui: 0 Bytes (0.00%)
  • common: 72.42 KiB (1.50%)

@zone-live zone-live merged commit 212e263 into develop Oct 13, 2023
9 checks passed
@zone-live zone-live deleted the MMI-update-metamask-keyring-controller branch October 13, 2023 13:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.4.0 Issue or pull request that will be included in release 11.4.0 release-11.5.0 Issue or pull request that will be included in release 11.5.0 release-blocker This bug is blocking the next release team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants