-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MMI] updates metamask/keyring-controller package to latest version #21367
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/[email protected] |
@metamaskbot update-policies |
Policies updated |
Builds ready [ec5c921]
Page Load Metrics (1109 ± 438 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21367 +/- ##
========================================
Coverage 68.59% 68.59%
========================================
Files 1026 1026
Lines 40978 40978
Branches 10936 10936
========================================
Hits 28107 28107
Misses 12871 12871 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is not actually an MMI-specific change?
LGTM otherwise.
Hi @legobeat no 👍🏼 |
Builds ready [74a9a5d]
Page Load Metrics (1103 ± 437 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Bumps
@metamask/keyring-controller
package to the latest8.0.3
, in order to include the latest fix in the signTransaction method. This version is part of the latest Core release 82.0.0.Without it MMI won't work.
Pre-merge author checklist
Pre-merge reviewer checklist