-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Multichain: Fix useAccountTotalFiatBalance when getWeiHexFromDecimalValue returns "NaN" #21359
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
681be5d
to
8d4ec74
Compare
…malValue returns undefined
8d4ec74
to
f91683a
Compare
Builds ready [4cf4d2b]
Page Load Metrics (1234 ± 393 ms)
Bundle size diffs
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #21359 +/- ##
===========================================
- Coverage 68.59% 68.59% -0.00%
===========================================
Files 1026 1026
Lines 40979 40981 +2
Branches 10936 10937 +1
===========================================
+ Hits 28108 28109 +1
- Misses 12871 12872 +1
☔ View full report in Codecov by Sentry. |
Description
While onboarding with
MULTICHAIN
environment variable turned on, I noticed a crash upon initial loading screen. The cause wasgetWeiHexFromDecimalValue
returning "NaN" in this block:with params:
value
:"0"
fromCurrency
:"usd"
conversionRate
:0
Checking for valid output and returning
0x0
prevents the balance errorManual testing steps
MULTICHAIN=1 yarn start
_1. Remove your local Metamask
_2. Re-install and go through onboarding
_3. Get to home wallet screen without crashing
Related issues
Fixes #???
Pre-merge author checklist
Pre-merge reviewer checklist