Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump test-dapp to v7.2.0 #21358

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Bump test-dapp to v7.2.0 #21358

merged 5 commits into from
Oct 13, 2023

Conversation

digiwand
Copy link
Contributor

Description

Bump test-dapp to v7.2.0
See changes MetaMask/test-dapp#261.

Relates to https://github.com/MetaMask/MetaMask-planning/issues/1264

Manual Testing Steps

  1. Check circle ci runs
  2. Locally run tests in your environment yarn test:e2e:chrome

@digiwand digiwand requested a review from a team as a code owner October 12, 2023 19:35
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand marked this pull request as draft October 12, 2023 19:42
@digiwand digiwand force-pushed the build-npm-upgrade-test-dapp branch from 39af4f4 to 9a90b1a Compare October 12, 2023 19:48
@digiwand digiwand added team-confirmations-secure-ux-PR PRs from the confirmations team area-buildSystem related to our build system and removed area-buildSystem related to our build system labels Oct 12, 2023
@digiwand digiwand marked this pull request as ready for review October 12, 2023 20:07
@legobeat
Copy link
Contributor

@digiwand
Copy link
Contributor Author

Thanks @legobeat , thanks @tmashuang! merged in the commits @tmashuang created in the other PR

@jiexi
Copy link
Contributor

jiexi commented Oct 13, 2023

Changes look correct to me. Thanks for bringing this in to extension!

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b8c9f3f) 68.59% compared to head (3908b7e) 68.59%.
Report is 26 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21358   +/-   ##
========================================
  Coverage    68.59%   68.59%           
========================================
  Files         1026     1026           
  Lines        40981    40981           
  Branches     10936    10936           
========================================
  Hits         28108    28108           
  Misses       12873    12873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [3908b7e]
Page Load Metrics (1006 ± 436 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892021243115
domContentLoaded701891133015
load8423931006908436
domInteractive701891133015
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@tmashuang tmashuang merged commit c23b1b5 into develop Oct 13, 2023
9 checks passed
@tmashuang tmashuang deleted the build-npm-upgrade-test-dapp branch October 13, 2023 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.5.0 Issue or pull request that will be included in release 11.5.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants