Token amount sent displays 0 when input contains no decimals

[salimtb]

Description

Description

Problem: After sending a token with an amount that doesn’t include decimals (ie 3, 5, 2), the transaction history displays the actual amount sent as 0. If the amount sent has a decimal (ie. 3.1, 0.2), this bug does not exist.

Expected Behavior: The amount I send should be reflected in the transaction history.

the problem is related to the fact that in Javascript , the boolean expression of 0 return false

Manual testing steps

1 - GIVEN I am on the "Activity" page
2 - AFTER I send a token with a decimal amount
3 - WHEN I view the previous transaction
4 - THEN I see the correct token amount sent

Before

sending-erc20-0decimals.mp4

After

Screen.Recording.2023-09-04.at.17.35.17.mov

Related issues

_Fixes #18139

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[salimtb]

the problem is related to the fact that in Javascript , the boolean expression of 0 return false.

[metamaskbot]

Builds ready [4dd1249]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (966 ± 380 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	149	103	18	9
		domContentLoaded	66	143	95	24	11
		load	77	1946	966	792	380
		domInteractive	66	143	95	24	11

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 31 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5deed0e) 68.68% compared to head (4dd1249) 68.69%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21338   +/-   ##
========================================
  Coverage    68.68%   68.69%           
========================================
  Files         1019     1019           
  Lines        40878    40879    +1     
  Branches     10917    10918    +1     
========================================
+ Hits         28077    28078    +1     
  Misses       12801    12801           

Files	Coverage Δ
ui/hooks/useTokenDisplayValue.js	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.