Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Multichain: Use contants for AssetListConversionButton variants #21333

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

darkwing
Copy link
Contributor

Description

Since we're expecting one of three strings for the variant of AssetListConversionButton, we should make those keys a constant to be imported and used.

Manual testing steps

No functional change.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner October 12, 2023 01:11
@darkwing darkwing added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Oct 12, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (313abb1) 68.68% compared to head (6a92640) 68.69%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21333   +/-   ##
========================================
  Coverage    68.68%   68.69%           
========================================
  Files         1019     1019           
  Lines        40878    40879    +1     
  Branches     10917    10917           
========================================
+ Hits         28077    28078    +1     
  Misses       12801    12801           
Files Coverage Δ
ui/components/app/asset-list/asset-list.js 72.88% <ø> (ø)
ui/components/app/nfts-tab/nfts-tab.js 88.24% <ø> (ø)
...-conversion-button/asset-list-conversion-button.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [a44b569]
Page Load Metrics (1243 ± 362 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint901701182412
domContentLoaded721671082814
load8520591243753362
domInteractive721671082814
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 688 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [6a92640]
Page Load Metrics (1289 ± 335 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint82139100147
domContentLoaded7013795189
load8218591289697335
domInteractive7013795189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 681 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit 8235fa2 into develop Oct 13, 2023
9 checks passed
@darkwing darkwing deleted the asset-list-conversion-button-constants branch October 13, 2023 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.5.0 Issue or pull request that will be included in release 11.5.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants