-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Multichain: Use contants for AssetListConversionButton variants #21333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
added
the
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
label
Oct 12, 2023
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21333 +/- ##
========================================
Coverage 68.68% 68.69%
========================================
Files 1019 1019
Lines 40878 40879 +1
Branches 10917 10917
========================================
+ Hits 28077 28078 +1
Misses 12801 12801
☔ View full report in Codecov by Sentry. |
Builds ready [a44b569]
Page Load Metrics (1243 ± 362 ms)
Bundle size diffs
|
DDDDDanica
reviewed
Oct 12, 2023
ui/components/multichain/asset-list-conversion-button/asset-list-conversion-button.js
Show resolved
Hide resolved
Builds ready [6a92640]
Page Load Metrics (1289 ± 335 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Oct 12, 2023
NidhiKJha
approved these changes
Oct 13, 2023
metamaskbot
added
the
release-11.5.0
Issue or pull request that will be included in release 11.5.0
label
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.5.0
Issue or pull request that will be included in release 11.5.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we're expecting one of three strings for the variant of
AssetListConversionButton
, we should make those keys a constant to be imported and used.Manual testing steps
No functional change.
Pre-merge author checklist
Pre-merge reviewer checklist