-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(codeowners): add privacy reviewers to codeowners #21241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to add the team to repo from the repo settings so we all good. |
Builds ready [14b6435]
Page Load Metrics (1149 ± 370 ms)
Bundle size diffs
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21241 +/- ##
========================================
Coverage 68.63% 68.63%
========================================
Files 1017 1017
Lines 40790 40790
Branches 10896 10896
========================================
Hits 27996 27996
Misses 12794 12794 ☔ View full report in Codecov by Sentry. |
danjm
approved these changes
Oct 10, 2023
darkwing
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.4.0
Issue or pull request that will be included in release 11.4.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Further locks down the privacy snapshot by adding codeowners for the snapshot file. A new team for this was created by @danjm @MetaMask/extension-privacy-reviewers
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist