Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(codeowners): add privacy reviewers to codeowners #21241

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

brad-decker
Copy link
Contributor

@brad-decker brad-decker commented Oct 6, 2023

Description

Further locks down the privacy snapshot by adding codeowners for the snapshot file. A new team for this was created by @danjm @MetaMask/extension-privacy-reviewers

Manual testing steps

  1. In theory if you branch off this PR and change the codeowners, then push up your branch you'll see that the team has been added to the PR as a codeowner.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brad-decker
Copy link
Contributor Author

brad-decker commented Oct 6, 2023

Screenshot 2023-10-06 at 3 39 46 PM

We should confirm that this works, because i can link to the team but I cannot add as reviewer and this shows up in the code changes. Perhaps the team isn't public or hasn't been indexed yet

Resolved now, had to add the team to the repo

@brad-decker
Copy link
Contributor Author

brad-decker commented Oct 6, 2023

Or perhaps @danjm we need to specifically add this repo to that team?

I was able to add the team to repo from the repo settings so we all good.

@brad-decker brad-decker requested a review from a team October 6, 2023 20:43
@metamaskbot
Copy link
Collaborator

Builds ready [14b6435]
Page Load Metrics (1149 ± 370 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81137106168
domContentLoaded68134103189
load8419461149771370
domInteractive68134102189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c32d063) 68.63% compared to head (14b6435) 68.63%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21241   +/-   ##
========================================
  Coverage    68.63%   68.63%           
========================================
  Files         1017     1017           
  Lines        40790    40790           
  Branches     10896    10896           
========================================
  Hits         27996    27996           
  Misses       12794    12794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brad-decker brad-decker merged commit b8b3dd6 into develop Oct 10, 2023
11 checks passed
@brad-decker brad-decker deleted the add-privacy-reviewer-codeowners branch October 10, 2023 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
@metamaskbot metamaskbot added the release-11.4.0 Issue or pull request that will be included in release 11.4.0 label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.4.0 Issue or pull request that will be included in release 11.4.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants