Adopt new version of `@metamask/signature-controller` to add signature operation logs #21207

OGPoyraz · 2023-10-05T09:06:46Z

Description

This PR aims to update @metamask/signature-controller@^6.1.2 in order to adopt add logs on signature operations.

Manual testing steps

There is no functional change in signatures. But if you get signature request, sign or rejects, that should end up in MetaMask State Logs.json which could be downloaded under Settings>Download State Logs

Screenshots/Recordings

I am adding an example of state logs as a proof. (Please note that I've removed locale messages to make file a bit smaller)
MetaMask state logs.txt

Related issues

_Fixes https://github.com/MetaMask/MetaMask-planning/issues/1321

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

OGPoyraz · 2023-10-05T09:10:03Z

@metamaskbot update-policies

metamaskbot · 2023-10-05T09:22:33Z

Policies updated

metamaskbot · 2023-10-05T11:54:56Z

Builds ready [49b417d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1104 ± 429 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	168	123	21	10
		domContentLoaded	77	162	112	21	10
		load	89	2333	1104	894	429
		domInteractive	77	162	112	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 18.19 KiB (0.50%)
ui: 0 Bytes (0.00%)
common: 36.08 KiB (0.75%)

codecov · 2023-10-06T07:04:56Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e614498) 68.61% compared to head (552ae81) 68.62%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #21207      +/-   ##
===========================================
+ Coverage    68.61%   68.62%   +0.01%     
===========================================
  Files         1028     1028              
  Lines        41021    41018       -3     
  Branches     10958    10958              
===========================================
+ Hits         28145    28148       +3     
+ Misses       12876    12870       -6

Files	Coverage Δ
app/scripts/metamask-controller.js	`53.76% <ø> (+0.18%)`	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-10-06T07:15:33Z

Builds ready [d76fe18]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1047 ± 411 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	184	114	23	11
		domContentLoaded	70	182	105	28	13
		load	91	2006	1047	857	411
		domInteractive	70	182	105	28	13

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 18.19 KiB (0.50%)
ui: 0 Bytes (0.00%)
common: 36.08 KiB (0.75%)

sleepytanya · 2023-10-09T13:55:50Z

Signature requests are logged in MetaMask State Logs.json

logs.pdf

socket-security · 2023-10-12T07:48:34Z

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

OGPoyraz · 2023-10-12T07:54:35Z

@metamaskbot update-policies

metamaskbot · 2023-10-12T08:07:00Z

Policies updated

metamaskbot · 2023-10-12T10:35:27Z

Builds ready [d07b619]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1416 ± 465 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	172	129	21	10
		domContentLoaded	71	169	120	29	14
		load	83	2436	1416	969	465
		domInteractive	71	169	120	29	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 18.45 KiB (0.51%)
ui: 0 Bytes (0.00%)
common: 72.42 KiB (1.50%)

metamaskbot · 2023-10-12T10:36:17Z

Builds ready [d07b619]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1416 ± 465 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	172	129	21	10
		domContentLoaded	71	169	120	29	14
		load	83	2436	1416	969	465
		domInteractive	71	169	120	29	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 18.45 KiB (0.51%)
ui: 0 Bytes (0.00%)
common: 72.42 KiB (1.50%)

OGPoyraz · 2023-10-16T10:45:58Z

@metamaskbot update-policies

metamaskbot · 2023-10-16T10:57:05Z

Policies updated

metamaskbot · 2023-10-16T11:40:36Z

Builds ready [552ae81]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1223 ± 432 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	167	127	18	9
		domContentLoaded	89	166	119	22	11
		load	106	2177	1223	900	432
		domInteractive	89	166	119	22	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 49.91 KiB (1.33%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

OGPoyraz requested a review from a team as a code owner October 5, 2023 09:06

OGPoyraz added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Oct 5, 2023

OGPoyraz requested review from a team as code owners October 5, 2023 09:22

brad-decker previously approved these changes Oct 5, 2023

View reviewed changes

matthewwalsh0 previously approved these changes Oct 11, 2023

View reviewed changes

vinistevam previously approved these changes Oct 11, 2023

View reviewed changes

OGPoyraz dismissed stale reviews from vinistevam, matthewwalsh0, and brad-decker via f044ac4 October 12, 2023 07:45

OGPoyraz force-pushed the 1321-adopt-signature-controller-logging-in-extension branch from d76fe18 to f044ac4 Compare October 12, 2023 07:45

matthewwalsh0 previously approved these changes Oct 12, 2023

View reviewed changes

vinistevam previously approved these changes Oct 16, 2023

View reviewed changes

OGPoyraz added 4 commits October 16, 2023 12:12

Update version of @metamask/signature-controller

69ec56e

yarn dedupe

8b9a5c9

fix lock file

ec091ab

Update yarn lock

43c2527

OGPoyraz dismissed stale reviews from vinistevam and matthewwalsh0 via 43c2527 October 16, 2023 10:14

OGPoyraz force-pushed the 1321-adopt-signature-controller-logging-in-extension branch from d07b619 to 43c2527 Compare October 16, 2023 10:14

Update LavaMoat policies

552ae81

matthewwalsh0 approved these changes Oct 16, 2023

View reviewed changes

vinistevam approved these changes Oct 16, 2023

View reviewed changes

OGPoyraz merged commit 1a597a5 into develop Oct 16, 2023
9 checks passed

OGPoyraz deleted the 1321-adopt-signature-controller-logging-in-extension branch October 16, 2023 13:01

github-actions bot locked and limited conversation to collaborators Oct 16, 2023

metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adopt new version of `@metamask/signature-controller` to add signature operation logs #21207

Adopt new version of `@metamask/signature-controller` to add signature operation logs #21207

OGPoyraz commented Oct 5, 2023 •

edited

Loading

OGPoyraz commented Oct 5, 2023

metamaskbot commented Oct 5, 2023

metamaskbot commented Oct 5, 2023

codecov bot commented Oct 6, 2023 •

edited

Loading

metamaskbot commented Oct 6, 2023

sleepytanya commented Oct 9, 2023 •

edited

Loading

socket-security bot commented Oct 12, 2023 •

edited

Loading

OGPoyraz commented Oct 12, 2023

metamaskbot commented Oct 12, 2023

metamaskbot commented Oct 12, 2023

metamaskbot commented Oct 12, 2023

OGPoyraz commented Oct 16, 2023

metamaskbot commented Oct 16, 2023

metamaskbot commented Oct 16, 2023

Adopt new version of @metamask/signature-controller to add signature operation logs #21207

Adopt new version of @metamask/signature-controller to add signature operation logs #21207

Conversation

OGPoyraz commented Oct 5, 2023 • edited Loading

Description

Manual testing steps

Screenshots/Recordings

Related issues

Pre-merge author checklist

Pre-merge reviewer checklist

OGPoyraz commented Oct 5, 2023

metamaskbot commented Oct 5, 2023

metamaskbot commented Oct 5, 2023

codecov bot commented Oct 6, 2023 • edited Loading

Codecov Report

metamaskbot commented Oct 6, 2023

sleepytanya commented Oct 9, 2023 • edited Loading

socket-security bot commented Oct 12, 2023 • edited Loading

OGPoyraz commented Oct 12, 2023

metamaskbot commented Oct 12, 2023

metamaskbot commented Oct 12, 2023

metamaskbot commented Oct 12, 2023

OGPoyraz commented Oct 16, 2023

metamaskbot commented Oct 16, 2023

metamaskbot commented Oct 16, 2023

Adopt new version of `@metamask/signature-controller` to add signature operation logs #21207

Adopt new version of `@metamask/signature-controller` to add signature operation logs #21207

OGPoyraz commented Oct 5, 2023 •

edited

Loading

codecov bot commented Oct 6, 2023 •

edited

Loading

sleepytanya commented Oct 9, 2023 •

edited

Loading

socket-security bot commented Oct 12, 2023 •

edited

Loading