-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MMI] Remove Whats-new-popup mmi code fences #21146
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ub.com/MetaMask/metamask-extension into MMI-3818-Add-Whats-new-popup-unit-test
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21146 +/- ##
===========================================
+ Coverage 68.49% 68.50% +0.01%
===========================================
Files 1012 1012
Lines 40588 40574 -14
Branches 10843 10838 -5
===========================================
- Hits 27799 27792 -7
+ Misses 12789 12782 -7
☔ View full report in Codecov by Sentry. |
Builds ready [11ba515]
Page Load Metrics (866 ± 369 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏼
Explanation
Remove Whats-new-popup mmi code fences. Currently, those code fences are doing nothing, and we don't have any plans yet to add custom mmi popups.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.