Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Remove Whats-new-popup mmi code fences #21146

Merged
merged 7 commits into from
Oct 2, 2023

Conversation

albertolive
Copy link
Contributor

Explanation

Remove Whats-new-popup mmi code fences. Currently, those code fences are doing nothing, and we don't have any plans yet to add custom mmi popups.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@albertolive albertolive requested a review from a team as a code owner October 2, 2023 12:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@albertolive albertolive added the team-mmi PRs from the MMI team label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b7ad9f6) 68.49% compared to head (11ba515) 68.50%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21146      +/-   ##
===========================================
+ Coverage    68.49%   68.50%   +0.01%     
===========================================
  Files         1012     1012              
  Lines        40588    40574      -14     
  Branches     10843    10838       -5     
===========================================
- Hits         27799    27792       -7     
+ Misses       12789    12782       -7     
Files Coverage Δ
.../components/app/whats-new-popup/whats-new-popup.js 40.91% <100.00%> (-1.16%) ⬇️
ui/pages/home/home.component.js 46.83% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [11ba515]
Page Load Metrics (866 ± 369 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84133100136
domContentLoaded7112393157
load811760866769369
domInteractive7112393157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -6 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@zone-live zone-live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@albertolive albertolive merged commit fcefc0f into develop Oct 2, 2023
9 checks passed
@albertolive albertolive deleted the MMI-3818-Add-Whats-new-popup-unit-test branch October 2, 2023 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants