Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Add Account-list-item-menu unit test #21138

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

albertolive
Copy link
Contributor

Explanation

Add Account-list-item-menu unit test

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@albertolive albertolive added the team-mmi PRs from the MMI team label Oct 2, 2023
@albertolive albertolive requested a review from a team as a code owner October 2, 2023 08:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6a7809f]
Page Load Metrics (1253 ± 360 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90163109199
domContentLoaded76145100178
load9019071253750360
domInteractive76145100178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0a215ca) 68.43% compared to head (6a7809f) 68.45%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21138      +/-   ##
===========================================
+ Coverage    68.43%   68.45%   +0.02%     
===========================================
  Files         1012     1012              
  Lines        40492    40492              
  Branches     10825    10825              
===========================================
+ Hits         27707    27715       +8     
+ Misses       12785    12777       -8     
Files Coverage Δ
...n/account-list-item-menu/account-list-item-menu.js 80.00% <ø> (+14.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertolive albertolive merged commit b8591ea into develop Oct 2, 2023
9 checks passed
@albertolive albertolive deleted the MMI-3819-Add-Account-list-item-menu-unit-test branch October 2, 2023 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants