Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use svg for blockaid what's new instead of PNG #21115

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Sep 29, 2023

Description

Replace blockaid what's new PNG image with SVG

Manual testing steps

  1. Delete MetaMask
  2. Start MetaMask with yarn start:flask
  3. Install MetaMask
  4. You should see blockaid what's new icon

Screenshots/Recordings

Screenshot 2023-09-29 at 14 17 36

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun requested a review from a team as a code owner September 29, 2023 13:19
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5edceb2) 68.46% compared to head (e681d2d) 68.46%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21115   +/-   ##
========================================
  Coverage    68.46%   68.46%           
========================================
  Files         1012     1012           
  Lines        40449    40449           
  Branches     10790    10790           
========================================
  Hits         27693    27693           
  Misses       12756    12756           
Files Coverage Δ
shared/notifications/index.js 56.36% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PRs from the confirmations team label Sep 29, 2023
@segun segun merged commit fd4bc6e into develop Sep 29, 2023
10 of 11 checks passed
@segun segun deleted the olu/blockaid-whats-new-use-svg branch September 29, 2023 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 29, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [e681d2d]
Page Load Metrics (1048 ± 371 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84144105168
domContentLoaded7214496168
load8719661048772371
domInteractive7214496168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants