-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move flask E2E tests to separate folder #21111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update codeowners.
matthewwalsh0
added
the
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
label
Sep 28, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21111 +/- ##
========================================
Coverage 68.49% 68.49%
========================================
Files 1010 1010
Lines 40398 40398
Branches 10788 10788
========================================
Hits 27669 27669
Misses 12729 12729 ☔ View full report in Codecov by Sentry. |
Builds ready [ac9a6af]
Page Load Metrics (835 ± 391 ms)
Bundle size diffs
|
HowardBraham
approved these changes
Sep 29, 2023
montelaidev
approved these changes
Sep 29, 2023
danjm
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
Mrtenz
approved these changes
Sep 29, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently all flask specific E2E tests are ran by the
test-e2e-chrome-snaps-flask
andtest-e2e-firefox-snaps-flask
pipeline jobs.To achieve this they are placed in the
test/e2e/snaps
folder, however as allsnaps
directories are owned by the@MetaMask/snaps-devs
, this creates a dependency where an approval from the snaps team is required for any unrelated change to these flask E2E tests.Pending a larger refactor to organise the E2E pipeline jobs by build type, this PR simply moves the flask specific E2E tests into a separate directory and updates the codeowners so both extension and snaps developers own
flask
folders since the flask build type is now used by any team wishing to trial new functionality outside of the main release.Pre-merge author checklist
Pre-merge reviewer checklist