Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flask E2E tests to separate folder #21111

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Sep 28, 2023

Description

Currently all flask specific E2E tests are ran by the test-e2e-chrome-snaps-flask and test-e2e-firefox-snaps-flask pipeline jobs.

To achieve this they are placed in the test/e2e/snaps folder, however as all snaps directories are owned by the @MetaMask/snaps-devs, this creates a dependency where an approval from the snaps team is required for any unrelated change to these flask E2E tests.

Pending a larger refactor to organise the E2E pipeline jobs by build type, this PR simply moves the flask specific E2E tests into a separate directory and updates the codeowners so both extension and snaps developers own flask folders since the flask build type is now used by any team wishing to trial new functionality outside of the main release.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Sep 28, 2023
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review September 28, 2023 22:18
@matthewwalsh0 matthewwalsh0 requested review from kumavis and a team as code owners September 28, 2023 22:18
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12c9d97) 68.49% compared to head (ac9a6af) 68.49%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21111   +/-   ##
========================================
  Coverage    68.49%   68.49%           
========================================
  Files         1010     1010           
  Lines        40398    40398           
  Branches     10788    10788           
========================================
  Hits         27669    27669           
  Misses       12729    12729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [ac9a6af]
Page Load Metrics (835 ± 391 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881169884
domContentLoaded7013694178
load821901835814391
domInteractive7013594178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@matthewwalsh0 matthewwalsh0 merged commit c686a18 into develop Sep 29, 2023
11 checks passed
@matthewwalsh0 matthewwalsh0 deleted the chore/flask-e2e-directory branch September 29, 2023 09:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants