Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(000): fix lint for account-list-item-menu and token-allowance #21094

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Sep 28, 2023

Description

fix lint warning for

  • account-list-item-menu
  • prepare-swap-page.js

Manual testing steps

1. Step1:
2. Step2:
3. ...

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica requested a review from a team as a code owner September 28, 2023 13:48
@DDDDDanica DDDDDanica self-assigned this Sep 28, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

brad-decker
brad-decker previously approved these changes Sep 28, 2023
@DDDDDanica DDDDDanica force-pushed the fix/account-list-menu branch from 3c37bd2 to c6162b7 Compare September 29, 2023 09:02
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (57d3212) 68.58% compared to head (f9b0942) 68.58%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21094      +/-   ##
===========================================
- Coverage    68.58%   68.58%   -0.00%     
===========================================
  Files         1026     1026              
  Lines        40971    40973       +2     
  Branches     10935    10935              
===========================================
  Hits         28098    28098              
- Misses       12873    12875       +2     
Files Coverage Δ
...pages/swaps/prepare-swap-page/prepare-swap-page.js 69.25% <ø> (ø)
...n/account-list-item-menu/account-list-item-menu.js 77.19% <20.00%> (-2.81%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c6162b7]
Page Load Metrics (1256 ± 367 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89149109178
domContentLoaded73140101199
load8719881256764367
domInteractive73140101199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 58 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [75c9d54]
Page Load Metrics (1233 ± 316 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint83135105178
domContentLoaded75131102178
load8417541233659316
domInteractive75131102178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 58 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f9b0942]
Page Load Metrics (1321 ± 390 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93139107126
domContentLoaded7212099136
load8821811321813390
domInteractive7212099136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 58 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica merged commit 5c7ac0f into develop Oct 13, 2023
9 checks passed
@DDDDDanica DDDDDanica deleted the fix/account-list-menu branch October 13, 2023 14:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.5.0 Issue or pull request that will be included in release 11.5.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants