-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display warning when sending zero tokens #21091
fix: display warning when sending zero tokens #21091
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
662fdd5
to
325b7a0
Compare
9cadcca
to
dde4de7
Compare
dde4de7
to
dabe6ba
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21091 +/- ##
===========================================
+ Coverage 68.49% 68.50% +0.01%
===========================================
Files 1010 1010
Lines 40398 40412 +14
Branches 10788 10797 +9
===========================================
+ Hits 27669 27683 +14
Misses 12729 12729
☔ View full report in Codecov by Sentry. |
Builds ready [dabe6ba]
Page Load Metrics (925 ± 391 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :D
Description
This PR display a warning when the user attempts to send zero amount in tokens/native currency.
Manual testing steps
_1. Click on any token
_2. Click Send
_3. Enter zero as amount
_4. Click next and notice the display of warning.
Screenshots/Recordings
Before
After
Sending zero ETH
Sending zero token (DAI)
Not displayed when sending amount in ETH !== 0
Not displayed when sending amount of tokens different than zero
Related issues
_Fixes #MMASSETS-44
Pre-merge author checklist
Pre-merge reviewer checklist