-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MMI] Add Signature-request-original.component unit test #21090
Merged
albertolive
merged 3 commits into
develop
from
MMI-3812-Add-Signature-request-original.component-unit-test
Sep 28, 2023
Merged
[MMI] Add Signature-request-original.component unit test #21090
albertolive
merged 3 commits into
develop
from
MMI-3812-Add-Signature-request-original.component-unit-test
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
albertolive
requested review from
DDDDDanica,
pedronfigueiredo and
NidhiKJha
September 28, 2023 12:31
DDDDDanica
previously approved these changes
Sep 28, 2023
NidhiKJha
previously approved these changes
Sep 28, 2023
pedronfigueiredo
previously approved these changes
Sep 28, 2023
albertolive
dismissed stale reviews from pedronfigueiredo and NidhiKJha
via
September 28, 2023 12:57
d1da372
albertolive
requested review from
DDDDDanica,
NidhiKJha and
pedronfigueiredo
September 28, 2023 12:57
NidhiKJha
approved these changes
Sep 28, 2023
DDDDDanica
approved these changes
Sep 28, 2023
Builds ready [d1da372]
Page Load Metrics (1009 ± 359 ms)
Bundle size diffs
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21090 +/- ##
========================================
Coverage 68.42% 68.43%
========================================
Files 1008 1008
Lines 40321 40321
Branches 10783 10783
========================================
+ Hits 27589 27590 +1
+ Misses 12732 12731 -1
☔ View full report in Codecov by Sentry. |
albertolive
deleted the
MMI-3812-Add-Signature-request-original.component-unit-test
branch
September 28, 2023 13:47
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-mmi
PRs from the MMI team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add Signature-request-original.component unit test
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.