Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Add Signature-request-original.component unit test #21090

Conversation

albertolive
Copy link
Contributor

Explanation

Add Signature-request-original.component unit test

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@albertolive albertolive added the team-mmi PRs from the MMI team label Sep 28, 2023
@albertolive albertolive requested a review from a team as a code owner September 28, 2023 12:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

DDDDDanica
DDDDDanica previously approved these changes Sep 28, 2023
NidhiKJha
NidhiKJha previously approved these changes Sep 28, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [d1da372]
Page Load Metrics (1009 ± 359 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint83131101136
domContentLoaded7112494147
load8019401009748359
domInteractive7112494157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d1310d9) 68.42% compared to head (d1da372) 68.43%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21090   +/-   ##
========================================
  Coverage    68.42%   68.43%           
========================================
  Files         1008     1008           
  Lines        40321    40321           
  Branches     10783    10783           
========================================
+ Hits         27589    27590    +1     
+ Misses       12732    12731    -1     
Files Coverage Δ
...t-original/signature-request-original.component.js 58.00% <ø> (+1.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertolive albertolive merged commit 0ee64b9 into develop Sep 28, 2023
9 checks passed
@albertolive albertolive deleted the MMI-3812-Add-Signature-request-original.component-unit-test branch September 28, 2023 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants