Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(000): fix lint for signature-request-siwe and metametrics #21089

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

DDDDDanica
Copy link
Contributor

Description

  • fixed lint warning for signature-request-siwe and metametrics
  • removed redundant types in Box.types

Manual testing steps

1. Step1:
2. Step2:
3. ...

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [72ca3b5]
Page Load Metrics (1306 ± 379 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87146111199
domContentLoaded75146105199
load8620671306790379
domInteractive75146105199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 81 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d1310d9) 68.42% compared to head (72ca3b5) 68.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21089      +/-   ##
===========================================
- Coverage    68.42%   68.42%   -0.00%     
===========================================
  Files         1008     1008              
  Lines        40321    40322       +1     
  Branches     10783    10783              
===========================================
  Hits         27589    27589              
- Misses       12732    12733       +1     
Files Coverage Δ
...p/signature-request-siwe/signature-request-siwe.js 71.93% <ø> (ø)
ui/contexts/metametrics.js 26.67% <0.00%> (-0.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDDDDanica DDDDDanica merged commit ac63a05 into develop Sep 28, 2023
13 checks passed
@DDDDDanica DDDDDanica deleted the fix/signature-request-siwe branch September 28, 2023 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants