Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get snap name if it's a snap dialog #21088

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Only get snap name if it's a snap dialog #21088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ui/pages/confirmation/confirmation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,18 +216,19 @@ export default function ConfirmationPage({
getTargetSubjectMetadata(state, pendingConfirmation?.origin),
);

// When pendingConfirmation is undefined, this will also be undefined
const snapName =
targetSubjectMetadata &&
getSnapName(pendingConfirmation?.origin, targetSubjectMetadata);

const SNAP_DIALOG_TYPE = [
ApprovalType.SnapDialogAlert,
ApprovalType.SnapDialogConfirmation,
ApprovalType.SnapDialogPrompt,
];

const isSnapDialog = SNAP_DIALOG_TYPE.includes(pendingConfirmation?.type);

// When pendingConfirmation is undefined, this will also be undefined
const snapName =
isSnapDialog &&
targetSubjectMetadata &&
getSnapName(pendingConfirmation?.origin, targetSubjectMetadata);
///: END:ONLY_INCLUDE_IN

const INPUT_STATE_CONFIRMATIONS = [
Expand Down