Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bridge button visibility #21085

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Update Bridge button visibility #21085

merged 2 commits into from
Sep 28, 2023

Conversation

micaelae
Copy link
Member

Description

  • Updates bridge constants with a new supported network (zkSync). This enables the Bridge button in the EthOverview page when the zkSync network is selected
  • Updates bridge constants with latest allowlisted tokens. This makes the Bridge button visible in the TokenOverview page when applicable

Manual testing steps

  1. Open the extension
  2. Select the zkSync network
  3. Verify that Bridge button is enabled and opens the portfolio page when clicked
  4. Open the extension
  5. Select the Ethereum network
  6. Import the RETH token: 0xae78736cd615f374d3085123a210448e74fc6393
  7. The Bridge button should be visible in the TokenOverview page

Screenshots/Recordings

Before

Screenshot 2023-09-27 at 2 35 18 PM Screenshot 2023-09-27 at 2 35 04 PM

After

Screenshot 2023-09-27 at 2 35 40 PM Screenshot 2023-09-27 at 2 34 02 PM

Related issues

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae requested a review from a team as a code owner September 27, 2023 21:42
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cc2880d) 68.40% compared to head (4e7f0fc) 68.40%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21085   +/-   ##
========================================
  Coverage    68.40%   68.40%           
========================================
  Files         1008     1008           
  Lines        40301    40301           
  Branches     10778    10778           
========================================
  Hits         27565    27565           
  Misses       12736    12736           
Files Coverage Δ
shared/constants/bridge.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4e7f0fc]
Page Load Metrics (833 ± 387 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint83163111199
domContentLoaded68139100199
load821933833806387
domInteractive68139100199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 680 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae merged commit 05241ee into develop Sep 28, 2023
11 checks passed
@micaelae micaelae deleted the bridge/button-visibility branch September 28, 2023 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-portfolio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants