Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup unused code after #21021 #21082

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

HowardBraham
Copy link
Contributor

Description

After #21021 was merged, there's now dangling unused code. This PR deletes it.

@HowardBraham HowardBraham requested review from a team as code owners September 27, 2023 18:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@HowardBraham HowardBraham self-assigned this Sep 27, 2023
@HowardBraham HowardBraham added team-accounts needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 27, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [e2e31b2]
Page Load Metrics (924 ± 397 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89143111168
domContentLoaded72135101199
load831891924826397
domInteractive72135101199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c2bda35) 68.40% compared to head (2bc91f8) 68.40%.

❗ Current head 2bc91f8 differs from pull request most recent head 26b4ff1. Consider uploading reports for the commit 26b4ff1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21082   +/-   ##
========================================
  Coverage    68.40%   68.40%           
========================================
  Files         1008     1008           
  Lines        40300    40300           
  Branches     10778    10778           
========================================
  Hits         27565    27565           
  Misses       12735    12735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

owencraston
owencraston previously approved these changes Sep 27, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [2bc91f8]
Page Load Metrics (1223 ± 350 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89139111157
domContentLoaded84138104167
load10318801223730350
domInteractive84138104167
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham merged commit cd179ec into develop Sep 27, 2023
9 checks passed
@HowardBraham HowardBraham deleted the chore/cleanup-unused-code branch September 27, 2023 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [26b4ff1]
Page Load Metrics (1001 ± 389 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861741062110
domContentLoaded7713397147
load8818581001811389
domInteractive7713397147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants