-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom headers in result pages #21076
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove site origin as not currently used.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
added
the
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
label
Sep 27, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21076 +/- ##
========================================
Coverage 68.38% 68.38%
========================================
Files 1008 1008
Lines 40288 40284 -4
Branches 10779 10773 -6
========================================
- Hits 27548 27546 -2
+ Misses 12740 12738 -2
☔ View full report in Codecov by Sentry. |
Builds ready [e29b1ac]
Page Load Metrics (1027 ± 402 ms)
Bundle size diffs
|
OGPoyraz
approved these changes
Sep 28, 2023
vinistevam
approved these changes
Sep 28, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes support for the
header
property when using the standardised result pages by callingApprovalController.success
orApprovalController.error
.Also removes the
SiteOrigin
component from theConfirmationPage
component as an incorrect condition meant it has not been used for the last 6 months and so reintroducing it without validation may cause undesirable visual changes.Manual Testing Steps
Not currently in use, fixing for adoption in progress.
Screenshots
Pre-merge Author Checklist
Pre-merge reviewer checklist