Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom headers in result pages #21076

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

matthewwalsh0
Copy link
Member

Description

Fixes support for the header property when using the standardised result pages by calling ApprovalController.success or ApprovalController.error.

Also removes the SiteOrigin component from the ConfirmationPage component as an incorrect condition meant it has not been used for the last 6 months and so reintroducing it without validation may cause undesirable visual changes.

Manual Testing Steps

Not currently in use, fixing for adoption in progress.

Screenshots

success_page_header error_page_header

Pre-merge Author Checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove site origin as not currently used.
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner September 27, 2023 15:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matthewwalsh0 matthewwalsh0 added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (89c40cb) 68.38% compared to head (e29b1ac) 68.38%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21076   +/-   ##
========================================
  Coverage    68.38%   68.38%           
========================================
  Files         1008     1008           
  Lines        40288    40284    -4     
  Branches     10779    10773    -6     
========================================
- Hits         27548    27546    -2     
+ Misses       12740    12738    -2     
Files Coverage Δ
ui/pages/confirmation/confirmation.js 63.57% <ø> (-0.32%) ⬇️
ui/pages/confirmation/templates/error.js 75.00% <ø> (-5.00%) ⬇️
ui/pages/confirmation/templates/success.js 75.00% <ø> (-5.00%) ⬇️
ui/pages/confirmation/util.ts 80.49% <100.00%> (+3.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e29b1ac]
Page Load Metrics (1027 ± 402 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92158109178
domContentLoaded741561022211
load8720091027838402
domInteractive741561022211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -550 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

@matthewwalsh0 matthewwalsh0 merged commit 0f7b7f3 into develop Sep 28, 2023
8 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/result-pages-header branch September 28, 2023 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants