Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy on remove snap modal #21065

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Sep 27, 2023

Description

Updates the copy on the remove snap modal to be more appropriate.

Fixes #21064

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 27, 2023
@FrederikBolding FrederikBolding requested review from a team as code owners September 27, 2023 14:18
david0xd
david0xd previously approved these changes Sep 27, 2023
GuillaumeRx
GuillaumeRx previously approved these changes Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6e4bf67) 68.35% compared to head (58eda69) 68.35%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21065   +/-   ##
========================================
  Coverage    68.35%   68.35%           
========================================
  Files         1007     1007           
  Lines        40269    40269           
  Branches     10773    10773           
========================================
  Hits         27524    27524           
  Misses       12745    12745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [58eda69]
Page Load Metrics (1321 ± 343 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89148119178
domContentLoaded83148110188
load9922011321715343
domInteractive83148110188
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -3 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit 9618d9e into develop Sep 27, 2023
9 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-remove-snap-copy branch September 27, 2023 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change copy in the snap removal confirmation popup
5 participants