-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copy on remove snap modal #21065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
added
the
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
label
Sep 27, 2023
david0xd
previously approved these changes
Sep 27, 2023
GuillaumeRx
previously approved these changes
Sep 27, 2023
FrederikBolding
dismissed stale reviews from GuillaumeRx and david0xd
via
September 27, 2023 14:36
58eda69
david0xd
approved these changes
Sep 27, 2023
hmalik88
approved these changes
Sep 27, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21065 +/- ##
========================================
Coverage 68.35% 68.35%
========================================
Files 1007 1007
Lines 40269 40269
Branches 10773 10773
========================================
Hits 27524 27524
Misses 12745 12745 ☔ View full report in Codecov by Sentry. |
Builds ready [58eda69]
Page Load Metrics (1321 ± 343 ms)
Bundle size diffs
|
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the copy on the remove snap modal to be more appropriate.
Fixes #21064