Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Add Signature-request unit test #21058

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

albertolive
Copy link
Contributor

Explanation

Add Signature-request unit test

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@albertolive albertolive added the team-mmi PRs from the MMI team label Sep 27, 2023
@albertolive albertolive requested a review from a team as a code owner September 27, 2023 09:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [8c3274a]
Page Load Metrics (850 ± 367 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8413098136
domContentLoaded7111990136
load791871850764367
domInteractive7111990136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -1 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6e4bf67) 68.35% compared to head (8c3274a) 68.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21058      +/-   ##
===========================================
+ Coverage    68.35%   68.37%   +0.02%     
===========================================
  Files         1007     1007              
  Lines        40269    40269              
  Branches     10773    10773              
===========================================
+ Hits         27524    27532       +8     
+ Misses       12745    12737       -8     
Files Coverage Δ
...ponents/app/signature-request/signature-request.js 83.10% <ø> (+8.45%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertolive albertolive merged commit d3cdb42 into develop Sep 27, 2023
11 checks passed
@albertolive albertolive deleted the MMI-3811-Add-Signature-request-unit-test branch September 27, 2023 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants