build: Remove duplicate @ethersproject/bignumber npm pkg and update to ^5.7.0

[digiwand]

Description

This PR removes a duplicate @ethersproject/bignumber npm package. keeps the one in dependencies and removes the other one from devDependencies.

This PR also updates the package from ^5.6.2 → ^5.7.0. I did not find any reasons to not do this.

Manual testing steps

build app and check app is working

Fixes #21055

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[legobeat]

Makes sense to not have the same package present in both dependencies and devDependencies 👍

Could we also bump the remaining dependencies entry in package.json to ^5.7.0?

[metamaskbot]

Builds ready [847300e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (839 ± 394 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	128	104	11	5
		domContentLoaded	68	116	93	13	6
		load	80	1896	839	822	394
		domInteractive	68	116	93	13	6

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[abdelrahmansheta16]

Hello @digiwand, can you explain how you have added labels to your PR, as this is my first time contributing to a github issue.

[digiwand]

Hello @abdelrahmansheta16, of course! on the browser version, there should be a "Labels" section on the right-hand side. clicking on it should allow you to search and add/remove labels. Mobile version is found in the "ⓘ" icon button.

you might have noticed a "Check PR has required labels / check-pr-labels" requirement check. This contains multiple checks including checking the label "external-contributor" (I believe this is the one you'll want) or the label prepended with "team-" exists.

in case you are interested in learning more about specific gh action checks, they can be found in the scripts folder. e.g. .github/scripts/check-pr-has-required-labels.ts.

thanks for asking! happy coding, and if you have any other questions, feel free to reach out again

[digiwand]

@legobeat ah, forgot to push up the changes. Updated to ^5.7.0. Thanks!

[abdelrahmansheta16]

@digiwand appreciate your response but as you can see in the image above there isn't any buttons near the "Label" section.

[digiwand]

@abdelrahmansheta16 this one

[abdelrahmansheta16]

@digiwand its unclickable

[digiwand]

@abdelrahmansheta16 o.0 odd. hm. I've added labels to your PR for now. Sorry to hear you're running into this. Not seeing a permission setting for this

There are no buttons but clicking on the label row with "Labels" should open the dropdown

[digiwand]

I think creating a comment thread for this will allow the conversation to continue after I merge

@abdelrahmansheta16 does your cursor change to a pointer hand when you hover over the row?

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8a54f65) 68.35% compared to head (9aa40d3) 68.35%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21054   +/-   ##
========================================
  Coverage    68.35%   68.35%           
========================================
  Files         1007     1007           
  Lines        40269    40269           
  Branches     10773    10773           
========================================
  Hits         27524    27524           
  Misses       12745    12745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [9aa40d3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1021 ± 409 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	178	114	25	12
		domContentLoaded	75	172	104	24	12
		load	88	2281	1021	852	409
		domInteractive	75	172	104	24	12

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)