-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand truncated address #21048
Expand truncated address #21048
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bae45c5
to
60628fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21048 +/- ##
========================================
Coverage 68.43% 68.43%
========================================
Files 1012 1012
Lines 40507 40507
Branches 10826 10826
========================================
Hits 27718 27718
Misses 12789 12789
☔ View full report in Codecov by Sentry. |
Builds ready [4d76afe]
Page Load Metrics (1168 ± 424 ms)
Bundle size diffs
|
Builds ready [dd343cb]
Page Load Metrics (1035 ± 398 ms)
Bundle size diffs
|
41e439f
dd343cb
to
41e439f
Compare
Looks good to me. would be more helpful to expand the instructions for manual tests for QA validation in the future :) |
41e439f
to
137644b
Compare
Builds ready [448d8e8]
Page Load Metrics (880 ± 373 ms)
Bundle size diffs
|
Fixes #20966
Description
We want to change our truncated addresses to a "0x12345...12345" format to give users more detail when selecting an account to connect with dapps.
Manual testing steps
1: Go to a dapp
2. Connect to a different wallet, or click the Connected Sites icon
3. Verify that address is now formatted as "0x12345...12345"
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist