Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand truncated address #21048

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Expand truncated address #21048

merged 8 commits into from
Sep 29, 2023

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented Sep 26, 2023

Fixes #20966

Description

We want to change our truncated addresses to a "0x12345...12345" format to give users more detail when selecting an account to connect with dapps.

Manual testing steps

1: Go to a dapp
2. Connect to a different wallet, or click the Connected Sites icon
3. Verify that address is now formatted as "0x12345...12345"

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vthomas13 vthomas13 force-pushed the vthomas13/issue20966 branch 3 times, most recently from bae45c5 to 60628fd Compare September 28, 2023 14:17
@vthomas13 vthomas13 added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Sep 28, 2023
@vthomas13 vthomas13 marked this pull request as ready for review September 28, 2023 15:38
@vthomas13 vthomas13 requested review from a team as code owners September 28, 2023 15:38
@vthomas13 vthomas13 changed the title WIP: Expand truncated address Expand truncated address Sep 28, 2023
brad-decker
brad-decker previously approved these changes Sep 28, 2023
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8fcd83b) 68.43% compared to head (448d8e8) 68.43%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21048   +/-   ##
========================================
  Coverage    68.43%   68.43%           
========================================
  Files         1012     1012           
  Lines        40507    40507           
  Branches     10826    10826           
========================================
  Hits         27718    27718           
  Misses       12789    12789           
Files Coverage Δ
shared/constants/labels.ts 100.00% <100.00%> (ø)
...ist-item/connected-accounts-list-item.component.js 75.00% <ø> (ø)
...accounts-list/connected-accounts-list.component.js 63.83% <ø> (ø)
ui/helpers/utils/util.js 84.87% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4d76afe]
Page Load Metrics (1168 ± 424 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881671162311
domContentLoaded741631022211
load8624041168883424
domInteractive741631022211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 454 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

legobeat
legobeat previously approved these changes Sep 29, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [dd343cb]
Page Load Metrics (1035 ± 398 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint971801202211
domContentLoaded781681132211
load9220761035829398
domInteractive781681132211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 454 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

DDDDDanica
DDDDDanica previously approved these changes Sep 29, 2023
@DDDDDanica
Copy link
Contributor

Looks good to me. would be more helpful to expand the instructions for manual tests for QA validation in the future :)

darkwing
darkwing previously approved these changes Sep 29, 2023
@vthomas13 vthomas13 dismissed stale reviews from darkwing and DDDDDanica via 137644b September 29, 2023 18:47
@metamaskbot
Copy link
Collaborator

Builds ready [448d8e8]
Page Load Metrics (880 ± 373 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89134109136
domContentLoaded7212698157
load851750880778373
domInteractive7212698157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 152 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@vthomas13 vthomas13 merged commit 547cbbf into develop Sep 29, 2023
9 checks passed
@vthomas13 vthomas13 deleted the vthomas13/issue20966 branch September 29, 2023 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand truncated address
6 participants