Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(000): fix lint for confirm-signature-request #21044

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

DDDDDanica
Copy link
Contributor

Description

fix lint warning in confirm-signature-request

Manual testing steps

1. Step1:
2. Step2:
3. ...

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (7e72f21) 68.39% compared to head (63cd420) 68.38%.
Report is 55 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21044      +/-   ##
===========================================
- Coverage    68.39%   68.38%   -0.01%     
===========================================
  Files         1007     1007              
  Lines        40252    40256       +4     
  Branches     10764    10767       +3     
===========================================
  Hits         27529    27529              
- Misses       12723    12727       +4     
Files Coverage Δ
ui/pages/confirm-signature-request/index.js 60.56% <29.03%> (-3.62%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDDDDanica DDDDDanica marked this pull request as ready for review September 26, 2023 13:20
@DDDDDanica DDDDDanica requested a review from a team as a code owner September 26, 2023 13:20
@metamaskbot
Copy link
Collaborator

Builds ready [63cd420]
Page Load Metrics (728 ± 368 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint82147109189
domContentLoaded721441012110
load791898728766368
domInteractive721441012110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 99 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica merged commit d1310d9 into develop Sep 28, 2023
12 checks passed
@DDDDDanica DDDDDanica deleted the fix/confirm-signature-request branch September 28, 2023 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants