Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix contract address display in confirmation page #21042

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Sep 26, 2023

Description

Sometimes the confirmation transaction page displays the destination wallet address rather than the contract address.

Here is related github issue: #19502.

Manual testing steps

_1. Go to : https://metamask.github.io/test-dapp/ or you can use etherscan on a contract address
_2. Deploy ERC1155 smart contract
_3. Call safeBatchTransferFrom function and notice the confirmation page does displays the destination address and not the contract address (side by side with the contract function name)

Screenshots/Recordings

Before

Calling mintBatch fct displays contract address correctly

image

Calling safeBatchTransferFrom fct displays the destination address instead:

image

After

Mint batch and safeTransferFromBatch display contract address

image

image

And if you are sending a transfer transaction (contractInteraction) to an address already imported in your wallet, it shows :

image

Related issues

Fixes #MMAssets-33

Pre-merge author checklist

  • [x ] I’ve followed MetaMask Coding Standards.
  • [ x] I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • [x ] I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • [ x] I’ve documented any added code.
  • [ x] I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner September 26, 2023 11:54
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Sep 26, 2023
@sahar-fehri sahar-fehri force-pushed the fix/MMASSETS-33-fix-contract-address-display branch from 0ae5da9 to abd1c10 Compare September 26, 2023 12:13
@sahar-fehri sahar-fehri changed the title fix: fix contract address display in confirmation page [WIP] fix: fix contract address display in confirmation page Sep 26, 2023
@sahar-fehri sahar-fehri force-pushed the fix/MMASSETS-33-fix-contract-address-display branch 4 times, most recently from eeeed9b to b55a326 Compare September 27, 2023 14:56
@metamaskbot
Copy link
Collaborator

Builds ready [b55a326]
Page Load Metrics (657 ± 335 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8112394126
domContentLoaded6512286178
load761631657698335
domInteractive6512286178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 26 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0a215ca) 68.43% compared to head (b52ccad) 68.43%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21042   +/-   ##
========================================
  Coverage    68.43%   68.43%           
========================================
  Files         1012     1012           
  Lines        40492    40495    +3     
  Branches     10825    10826    +1     
========================================
+ Hits         27707    27711    +4     
+ Misses       12785    12784    -1     
Files Coverage Δ
...ummary/confirm-page-container-summary.component.js 87.80% <100.00%> (+3.59%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahar-fehri sahar-fehri changed the title [WIP] fix: fix contract address display in confirmation page fix: fix contract address display in confirmation page Sep 27, 2023
@sahar-fehri sahar-fehri self-assigned this Sep 27, 2023
@sahar-fehri sahar-fehri force-pushed the fix/MMASSETS-33-fix-contract-address-display branch from b70eab7 to b52ccad Compare October 2, 2023 08:15
@metamaskbot
Copy link
Collaborator

Builds ready [b52ccad]
Page Load Metrics (713 ± 361 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89143102147
domContentLoaded71157942010
load811864713752361
domInteractive71157942010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 26 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sahar-fehri sahar-fehri merged commit 360ab36 into develop Oct 2, 2023
9 checks passed
@sahar-fehri sahar-fehri deleted the fix/MMASSETS-33-fix-contract-address-display branch October 2, 2023 15:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants