-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix contract address display in confirmation page #21042
Merged
sahar-fehri
merged 1 commit into
develop
from
fix/MMASSETS-33-fix-contract-address-display
Oct 2, 2023
Merged
fix: fix contract address display in confirmation page #21042
sahar-fehri
merged 1 commit into
develop
from
fix/MMASSETS-33-fix-contract-address-display
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
added
the
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
label
Sep 26, 2023
sahar-fehri
force-pushed
the
fix/MMASSETS-33-fix-contract-address-display
branch
from
September 26, 2023 12:13
0ae5da9
to
abd1c10
Compare
sahar-fehri
changed the title
fix: fix contract address display in confirmation page
[WIP] fix: fix contract address display in confirmation page
Sep 26, 2023
sahar-fehri
force-pushed
the
fix/MMASSETS-33-fix-contract-address-display
branch
4 times, most recently
from
September 27, 2023 14:56
eeeed9b
to
b55a326
Compare
Builds ready [b55a326]
Page Load Metrics (657 ± 335 ms)
Bundle size diffs
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21042 +/- ##
========================================
Coverage 68.43% 68.43%
========================================
Files 1012 1012
Lines 40492 40495 +3
Branches 10825 10826 +1
========================================
+ Hits 27707 27711 +4
+ Misses 12785 12784 -1
☔ View full report in Codecov by Sentry. |
sahar-fehri
commented
Sep 27, 2023
...container-content/confirm-page-container-summary/confirm-page-container-summary.component.js
Show resolved
Hide resolved
sahar-fehri
changed the title
[WIP] fix: fix contract address display in confirmation page
fix: fix contract address display in confirmation page
Sep 27, 2023
pedronfigueiredo
previously approved these changes
Sep 27, 2023
brad-decker
suggested changes
Sep 28, 2023
ui/pages/confirm-transaction-base/confirm-transaction-base.container.js
Outdated
Show resolved
Hide resolved
...container-content/confirm-page-container-summary/confirm-page-container-summary.component.js
Show resolved
Hide resolved
sahar-fehri
force-pushed
the
fix/MMASSETS-33-fix-contract-address-display
branch
from
October 2, 2023 08:14
c9474f5
to
b70eab7
Compare
sahar-fehri
force-pushed
the
fix/MMASSETS-33-fix-contract-address-display
branch
from
October 2, 2023 08:15
b70eab7
to
b52ccad
Compare
Builds ready [b52ccad]
Page Load Metrics (713 ± 361 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Oct 2, 2023
brad-decker
approved these changes
Oct 2, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the confirmation transaction page displays the destination wallet address rather than the contract address.
Here is related github issue: #19502.
Manual testing steps
_1. Go to : https://metamask.github.io/test-dapp/ or you can use etherscan on a contract address
_2. Deploy ERC1155 smart contract
_3. Call safeBatchTransferFrom function and notice the confirmation page does displays the destination address and not the contract address (side by side with the contract function name)
Screenshots/Recordings
Before
Calling mintBatch fct displays contract address correctly
Calling safeBatchTransferFrom fct displays the destination address instead:
After
Mint batch and safeTransferFromBatch display contract address
And if you are sending a transfer transaction (contractInteraction) to an address already imported in your wallet, it shows :
Related issues
Fixes #MMAssets-33
Pre-merge author checklist
Pre-merge reviewer checklist