-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add validation error on NFT import #21028
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
2b5d361
to
a638876
Compare
2aa0916
to
5ab689d
Compare
Builds ready [5ab689d]
Page Load Metrics (1735 ± 80 ms)
Bundle size diffs
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21028 +/- ##
===========================================
+ Coverage 68.35% 68.39% +0.05%
===========================================
Files 1007 1007
Lines 40260 40256 -4
Branches 10770 10765 -5
===========================================
+ Hits 27516 27533 +17
+ Misses 12744 12723 -21
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good @sahar-fehri , before I approve one follow-up question. Do we want to show the error message when the address field is blank, I think in this case we should not show any message.
0d67012
to
af32424
Compare
af32424
to
2ba0590
Compare
Builds ready [2ba0590]
Page Load Metrics (990 ± 347 ms)
Bundle size diffs
|
2ba0590
to
4c85958
Compare
…ion into fix/MMASSETS-35
Builds ready [504aac0]
Page Load Metrics (1044 ± 410 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adds an error msg if contract address is not validation on the NFT import modal.
(Just to make the behavior more consistent with the token-import modal)
Manual testing steps
_1. Click on "import nft" button in the NFT tab
_2. Add invalid contract address and notice error msg
Screenshots/Recordings
Before
After
Fixes
https://consensyssoftware.atlassian.net/browse/MMASSETS-35
Pre-merge author checklist
Pre-merge reviewer checklist