Fix dropdown for multiple transaction insight snaps

[david0xd]

Description

This PR will fix dropdown behaviour when multiple transaction insight snaps are available.
This PR will also refactor code in terms of removing deprecated UI components and constants.

Manual testing steps

1. Install multiple transaction insight Snaps.
2. Got to test dapp and send test transaction.
3. By clicking on the tab text, dropdown should not open.
4. By clicking on the dropdown arrow icon, dropdown should open.

Screenshots/Recordings

Before and After

Note: Before and after UI is the same, only click behaviour is changed. Only the padding of the clickable area is increased for small amount as requested from UI/UX engineer.

Related issues

Fixes: #20885

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e72f21) 68.39% compared to head (5182032) 68.39%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21022   +/-   ##
========================================
  Coverage    68.39%   68.39%           
========================================
  Files         1007     1007           
  Lines        40252    40252           
  Branches     10764    10764           
========================================
  Hits         27529    27529           
  Misses       12723    12723           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [d83062c]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1590 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	116	182	141	17	8
		domContentLoaded	1423	1906	1590	117	56
		load	1424	1907	1590	117	56
		domInteractive	1423	1906	1590	117	56

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 24 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [3c836fe]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1700 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	135	107	14	7
		domContentLoaded	72	136	100	16	8
		load	1553	2308	1700	182	87
		domInteractive	72	136	100	16	8

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -9 Bytes (-0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [d5ccbab]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (995 ± 428 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	158	121	20	9
		domContentLoaded	76	152	108	22	10
		load	90	2211	995	890	428
		domInteractive	76	152	108	22	10

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 51 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [5182032]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (475 ± 347 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	170	120	20	10
		domContentLoaded	77	169	104	24	11
		load	89	1969	475	724	347
		domInteractive	77	169	104	24	11

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 51 Bytes (0.00%)
• common: 0 Bytes (0.00%)