Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Multichain: Ensure all components have proptype docs #21018

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Sep 23, 2023

Description

Provides documentation for all components in the multichain directory

Manual testing steps

This PR has no functional change.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Sep 23, 2023
@darkwing darkwing requested a review from a team as a code owner September 23, 2023 02:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing force-pushed the multichain-prop-details branch from 6645d9a to d34b7cb Compare September 23, 2023 02:59
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8a16141) 68.34% compared to head (da691ef) 68.34%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21018   +/-   ##
========================================
  Coverage    68.34%   68.34%           
========================================
  Files         1007     1007           
  Lines        40254    40254           
  Branches     10761    10761           
========================================
  Hits         27508    27508           
  Misses       12746    12746           
Files Coverage Δ
...in/account-details/account-details-authenticate.js 89.47% <ø> (ø)
...tichain/account-details/account-details-display.js 80.00% <ø> (ø)
.../multichain/account-details/account-details-key.js 85.71% <ø> (ø)
...ents/multichain/account-details/account-details.js 71.43% <ø> (ø)
...n/account-list-item-menu/account-list-item-menu.js 65.45% <ø> (ø)
...ultichain/activity-list-item/activity-list-item.js 85.00% <ø> (ø)
...onents/multichain/create-account/create-account.js 90.91% <ø> (ø)
...onents/multichain/import-account/bottom-buttons.js 92.31% <100.00%> (ø)
...onents/multichain/import-account/import-account.js 21.74% <ø> (ø)
ui/components/multichain/import-account/json.js 75.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [da691ef]
Page Load Metrics (899 ± 386 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88136109126
domContentLoaded7211898157
load852022899804386
domInteractive7211898157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit e068be4 into develop Sep 26, 2023
9 checks passed
@darkwing darkwing deleted the multichain-prop-details branch September 26, 2023 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants