Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1120): remove toggle all in incoming-transaction-toggle #21012

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Sep 22, 2023

Description

There was a lag between design and develop that causing an extra feature developed. This MR is to remove "toggle all" in incoming txn privacy page

Manual testing steps

  1. Go to settings and Security & privacy page
  2. Navigate to Show incoming transactions section
  3. There is no toggle all option

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

Screenshot 2023-09-22 at 18 00 34

After

Screenshot 2023-09-22 at 18 07 06

Related issues

_Fixes #1120

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@DDDDDanica DDDDDanica force-pushed the feature/1120-remove-toggle-all branch from 138e90f to 76ea02a Compare September 22, 2023 17:11
@DDDDDanica DDDDDanica force-pushed the feature/1120-remove-toggle-all branch from 76ea02a to b188def Compare September 22, 2023 17:22
@DDDDDanica DDDDDanica merged commit 967ed42 into develop Sep 22, 2023
9 checks passed
@DDDDDanica DDDDDanica deleted the feature/1120-remove-toggle-all branch September 22, 2023 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [b188def]
Page Load Metrics (1554 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint117179142189
domContentLoaded14281897155412359
load14281898155412359
domInteractive14281897155412359
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -811 Bytes (-0.01%)
  • common: -57 Bytes (-0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants