Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ppom package #21009

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Updating ppom package #21009

merged 1 commit into from
Sep 25, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 22, 2023

Description

Update package @blockaid/ppom-release as blockaid team has published a new update with a couple of fixes.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner September 22, 2023 15:52
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d587999) 68.37% compared to head (058e08d) 68.37%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21009   +/-   ##
========================================
  Coverage    68.37%   68.37%           
========================================
  Files         1006     1006           
  Lines        40254    40254           
  Branches     10763    10763           
========================================
  Hits         27523    27523           
  Misses       12731    12731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [058e08d]
Page Load Metrics (1679 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint127195150168
domContentLoaded14841902167911455
load14851902167911455
domInteractive14841902167911455
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bschorchit bschorchit added team-confirmations-secure-ux-PR PRs from the confirmations team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Sep 24, 2023
@jpuri jpuri merged commit a797d88 into develop Sep 25, 2023
14 checks passed
@jpuri jpuri deleted the ppom_release_update branch September 25, 2023 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants