Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Add Jwt-url-form component unit test #21005

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Sep 22, 2023

Explanation

Add Jwt-url-form component unit test

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@albertolive albertolive added the team-mmi PRs from the MMI team label Sep 22, 2023
@albertolive albertolive requested a review from a team as a code owner September 22, 2023 13:22
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@albertolive albertolive changed the title [MMI] Added tests and improved component [MMI] Add Jwt-url-form component unit test Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (97bb2c4) 68.36% compared to head (2503a83) 68.37%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21005      +/-   ##
===========================================
+ Coverage    68.36%   68.37%   +0.01%     
===========================================
  Files         1006     1006              
  Lines        40262    40251      -11     
  Branches     10763    10761       -2     
===========================================
- Hits         27522    27520       -2     
+ Misses       12740    12731       -9     
Files Changed Coverage Δ
...ponents/institutional/jwt-url-form/jwt-url-form.js 100.00% <100.00%> (+27.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2503a83]
Page Load Metrics (1662 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint129182151168
domContentLoaded15112208166214268
load15112208166214268
domInteractive15112208166214268
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -52 Bytes (-0.00%)

@albertolive albertolive merged commit d587999 into develop Sep 22, 2023
9 checks passed
@albertolive albertolive deleted the MMI-3795-Add-Jwt-url-form-component-unit-test branch September 22, 2023 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants