-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MMI] fix property name and filter out custodian #21004
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approv
Builds ready [0aa1001]
Page Load Metrics (1647 ± 60 ms)
Bundle size diffs
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #21004 +/- ##
========================================
Coverage 68.36% 68.36%
========================================
Files 1006 1006
Lines 40262 40265 +3
Branches 10763 10765 +2
========================================
+ Hits 27522 27525 +3
Misses 12740 12740
☔ View full report in Codecov by Sentry. |
We were looking for the wrong property in the
findCustodianByDisplayName
method, and also we can filter out a custodian that we don't need from the list of custodians.Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.