Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] fix property name and filter out custodian #21004

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

zone-live
Copy link
Contributor

We were looking for the wrong property in the findCustodianByDisplayName method, and also we can filter out a custodian that we don't need from the list of custodians.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@zone-live zone-live requested a review from a team as a code owner September 22, 2023 11:09
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added team-mmi PRs from the MMI team release-11.2.0 Issue or pull request that will be included in release 11.2.0 labels Sep 22, 2023
Copy link

@Ameralameri Ameralameri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approv

@metamaskbot
Copy link
Collaborator

Builds ready [0aa1001]
Page Load Metrics (1647 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint125192151199
domContentLoaded14521965164712660
load14531965164712660
domInteractive14521965164712660
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (97bb2c4) 68.36% compared to head (0aa1001) 68.36%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #21004   +/-   ##
========================================
  Coverage    68.36%   68.36%           
========================================
  Files         1006     1006           
  Lines        40262    40265    +3     
  Branches     10763    10765    +2     
========================================
+ Hits         27522    27525    +3     
  Misses       12740    12740           
Files Changed Coverage Δ
...pers/utils/institutional/find-by-custodian-name.ts 100.00% <100.00%> (ø)
ui/pages/institutional/custody/custody.js 75.61% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live merged commit 1e65bb8 into develop Sep 22, 2023
10 of 11 checks passed
@zone-live zone-live deleted the MMI-fix-custodian-property-lookout branch September 22, 2023 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 22, 2023
@danjm danjm removed the release-11.2.0 Issue or pull request that will be included in release 11.2.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants