Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Add confirm add custodian token component unit test #21002

Conversation

albertolive
Copy link
Contributor

Explanation

Add confirm add custodian token component unit test

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@albertolive albertolive added the team-mmi PRs from the MMI team label Sep 22, 2023
@albertolive albertolive requested a review from a team as a code owner September 22, 2023 10:52
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (789c2f3) 68.33% compared to head (de1cf9e) 68.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21002      +/-   ##
===========================================
+ Coverage    68.33%   68.36%   +0.03%     
===========================================
  Files         1007     1007              
  Lines        40254    40252       -2     
  Branches     10761    10764       +3     
===========================================
+ Hits         27507    27517      +10     
+ Misses       12747    12735      -12     
Files Coverage Δ
...add-custodian-token/confirm-add-custodian-token.js 92.00% <96.43%> (+20.85%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [a4dd8ae]
Page Load Metrics (1569 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint120179146178
domContentLoaded1436172115698842
load1436172115698842
domInteractive1436172115698842
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

NidhiKJha
NidhiKJha previously approved these changes Sep 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [de1cf9e]
Page Load Metrics (1499 ± 286 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861621112010
domContentLoaded821571052110
load10620331499597286
domInteractive821561052110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@albertolive albertolive merged commit a7216fd into develop Sep 26, 2023
9 checks passed
@albertolive albertolive deleted the MMI-3794-Add-Confirm-add-custodian-token-component-unit-test branch September 26, 2023 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants