Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing metrics for token approval amount type #20999

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 22, 2023

Description

Fixes #20764
The PR fixes issue that metrics were showing custom even when user had approved DAPP Suggested value.

Manual testing steps

  1. Go to https://metamask.github.io/test-dapp/
  2. Create a token
  3. Approve a token (don't change the proposed spending cap in the MM popup)
  4. Notice how we'll be logging it as a dapp_proposed on the transaction_approval_amount_type

Related issues

_Fixes #20764

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 22, 2023
@jpuri jpuri requested a review from a team September 22, 2023 06:23
@jpuri jpuri requested a review from a team as a code owner September 22, 2023 06:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0bc3aa9) 68.38% compared to head (7048249) 68.38%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #20999   +/-   ##
========================================
  Coverage    68.38%   68.38%           
========================================
  Files         1006     1006           
  Lines        40244    40244           
  Branches     10759    10759           
========================================
  Hits         27517    27517           
  Misses       12727    12727           
Files Changed Coverage Δ
app/scripts/controllers/transactions/index.js 72.64% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [7048249]
Page Load Metrics (1787 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1222091572110
domContentLoaded15032005178713565
load15032005178713565
domInteractive15032004178713565
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 7 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit 7317e63 into develop Sep 27, 2023
11 checks passed
@jpuri jpuri deleted the approve_metrics_fix branch September 27, 2023 12:49
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Passing custom as the value for transaction_approval_amount_type property instead of dapp_proposed
4 participants