-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add petnames metrics #20994
Add petnames metrics #20994
Conversation
Create associated unit tests.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [97761f7]
Page Load Metrics (1442 ± 27 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #20994 +/- ##
===========================================
+ Coverage 68.41% 68.47% +0.06%
===========================================
Files 1012 1012
Lines 40508 40597 +89
Branches 10823 10841 +18
===========================================
+ Hits 27710 27796 +86
- Misses 12798 12801 +3
☔ View full report in Codecov by Sentry. |
Update proposed names from name details component. Truncate in name component. Truncate in name details component. Sort proposed names by source label.
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Move name detail metric logic into separate file.
Builds ready [b596e4e]
Page Load Metrics (884 ± 345 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Add metrics to monitor petnames usage, specifically the following events:
Petname Displayed
Petname Model Opened
Petname Created
Petname Updated
Petname Deleted
Plus the
petname_addresses_count
user trait.Also applies the following changes to the
Name
andNameDetails
components:Name
component.NameDetails
component.Name
component text using ellipsis.NameDetails
component using ellipsis.Related Issues
Fixes #1318
Pre-merge Author Checklist
Pre-merge reviewer checklist