Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @metamask/network-controller to v12.2.0 #20991

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Sep 21, 2023

Description

Bumps our NetworkController version to the recent release. Needed because this change requires a minor update to spec scaffolding and is breaking other branches that includes these changes in a preview build.

Manual testing steps

None should be necessary as this shouldn't cause any noticeable changes

Screenshots/Recordings

Before

After

Related issues

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi
Copy link
Contributor Author

jiexi commented Sep 21, 2023

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@jiexi
Copy link
Contributor Author

jiexi commented Sep 21, 2023

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@adonesky1
Copy link
Contributor

adonesky1 commented Sep 21, 2023

Relevant CHANGLOG entry

@jiexi jiexi marked this pull request as ready for review September 21, 2023 17:30
@jiexi jiexi requested review from a team as code owners September 21, 2023 17:30
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiexi jiexi merged commit f844dcf into develop Sep 21, 2023
9 checks passed
@jiexi jiexi deleted the jl/bump-network-controller-12.2.0 branch September 21, 2023 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 21, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [0eff5f6]
Page Load Metrics (1647 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1122001522311
domContentLoaded13611894164718287
load13611894164718287
domInteractive13611894164718287
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 9.42 KiB (0.26%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants