Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateCaveat not being exposed in the background API #20986

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

FrederikBolding
Copy link
Member

Description

Follow up to #20983

Fixes an issue where updateCaveat was not being exposed in the background API. This caused problems when trying to disconnect a single dapp from a snap. I had misdiagnosed the bug in the first PR and thought that it was fixed, but @NidhiKJha reported that it was still broken.

Manual testing steps

  1. Connect to 2 snaps from a single dapp
  2. Go to one of the snap's settings
  3. Disconnect from the dapp
  4. Go to the other snap's settings and check that you are not disconnected

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 21, 2023
@FrederikBolding FrederikBolding requested a review from a team as a code owner September 21, 2023 13:27
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [5d1857d]
Page Load Metrics (1700 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint133177154136
domContentLoaded15262274169916981
load15262274170016981
domInteractive15262274169916981
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 42 Bytes (0.00%)
  • ui: -403 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (452e177) 68.41% compared to head (5d1857d) 68.40%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20986      +/-   ##
===========================================
- Coverage    68.41%   68.40%   -0.02%     
===========================================
  Files         1006     1006              
  Lines        40205    40187      -18     
  Branches     10752    10743       -9     
===========================================
- Hits         27506    27487      -19     
- Misses       12699    12700       +1     
Files Changed Coverage Δ
app/scripts/metamask-controller.js 53.80% <0.00%> (-0.14%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NidhiKJha NidhiKJha merged commit 29ac616 into develop Sep 21, 2023
11 checks passed
@NidhiKJha NidhiKJha deleted the fb/fix-missing-exposed-api branch September 21, 2023 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants