Bump snaps packages and remove `-flask` versions #20984

FrederikBolding · 2023-09-21T12:57:08Z

Description

Bump snaps packages to latest. The latest packages include both the code previously contained in the -flask packages and the stable code. This lets us deduplicate the snaps packages in use.

FrederikBolding · 2023-09-21T13:04:56Z

@metamaskbot update-policies

metamaskbot · 2023-09-21T13:18:31Z

Policies updated

Mrtenz · 2023-09-22T12:29:57Z

shared/constants/snaps/permissions.ts

+  // Move to below fence once implemented
+  'endowment:name-lookup':
+    'This permission is still in development and therefore not available.',


Why can't we move this now?

IMO it should be disabled until we add an actual integration for it

metamaskbot · 2023-09-22T12:30:27Z

Builds ready [197fdb4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1682 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	188	155	24	12
		domContentLoaded	1439	1940	1682	143	69
		load	1439	1940	1682	143	69
		domInteractive	1439	1940	1682	143	69

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.49 KiB (0.07%)
ui: -7.96 KiB (-0.10%)
common: 16.01 KiB (0.35%)

codecov · 2023-09-22T12:30:35Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (25a054d) 68.33% compared to head (dd677d8) 68.34%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #20984   +/-   ##
========================================
  Coverage    68.33%   68.34%           
========================================
  Files         1007     1007           
  Lines        40254    40254           
  Branches     10761    10761           
========================================
+ Hits         27507    27508    +1     
+ Misses       12747    12746    -1

Files Changed	Coverage Δ
shared/constants/snaps/permissions.ts	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

socket-security · 2023-09-25T08:35:50Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/snaps-controllers	2.0.0	eval, network, shell	`+16`	7.89 MB	metamaskbot
@metamask/snaps-utils	2.0.0	filesystem, shell	`+7`	898 kB	metamaskbot
@metamask/snaps-ui	2.0.0	None	`+0`	59.2 kB	metamaskbot
@metamask/rpc-methods	2.0.0	None	`+8`	1.36 MB	metamaskbot
@metamask/post-message-stream	7.0.0	None	`+0`	75.9 kB	gudahtt
@metamask/providers	10.2.1...12.0.0	None	`+0/-9`	187 kB	metamaskbot

🚮 Removed packages: [email protected]

socket-security · 2023-09-25T08:35:53Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], @metamask/[email protected], @metamask/[email protected], @metamask/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

metamaskbot · 2023-09-25T08:52:05Z

Builds ready [fea7364]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1587 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	83	142	101	17	8
		domContentLoaded	74	135	97	17	8
		load	1462	1729	1587	83	40
		domInteractive	74	135	97	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.49 KiB (0.07%)
ui: -7.96 KiB (-0.10%)
common: 16.01 KiB (0.35%)

metamaskbot · 2023-09-25T10:22:02Z

Builds ready [72c2872]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1492 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	118	91	9	4
		domContentLoaded	72	112	86	10	5
		load	1412	1634	1492	61	29
		domInteractive	72	112	86	10	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.49 KiB (0.07%)
ui: -7.96 KiB (-0.10%)
common: 16.01 KiB (0.35%)

FrederikBolding · 2023-09-25T11:29:12Z

@SocketSecurity ignore [email protected]

NPM employee.

@SocketSecurity ignore @metamask/[email protected]
@SocketSecurity ignore @metamask/[email protected]
@SocketSecurity ignore @metamask/[email protected]

Ours.

metamaskbot · 2023-09-25T14:06:58Z

Builds ready [dd677d8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2063 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	103	184	132	23	11
		domContentLoaded	88	181	122	27	13
		load	1732	2415	2063	165	79
		domInteractive	88	181	122	27	13

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.49 KiB (0.07%)
ui: -7.96 KiB (-0.10%)
common: 16.01 KiB (0.35%)

FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 21, 2023

FrederikBolding force-pushed the fb/bump-snaps branch 2 times, most recently from 703a5ef to c21f4b6 Compare September 22, 2023 11:45

FrederikBolding marked this pull request as ready for review September 22, 2023 12:21

FrederikBolding requested review from a team and kumavis as code owners September 22, 2023 12:21

Mrtenz reviewed Sep 22, 2023

View reviewed changes

FrederikBolding and others added 8 commits September 25, 2023 09:50

Remove -flask snaps packages

18e56f1

Bump snaps packages

63523bc

Update LavaMoat policies

e356dbc

Bump missed package

40ecf3c

Fix tests

eccdca1

Re-enable an E2E in stable

31ced4d

Exclude name lookup for now

37fbf21

Fix test

fea7364

FrederikBolding force-pushed the fb/bump-snaps branch from 197fdb4 to fea7364 Compare September 25, 2023 07:55

Update MMI url

72c2872

GuillaumeRx approved these changes Sep 25, 2023

View reviewed changes

david0xd approved these changes Sep 25, 2023

View reviewed changes

Merge branch 'develop' into fb/bump-snaps

dd677d8

FrederikBolding merged commit ccb554a into develop Sep 25, 2023
9 checks passed

FrederikBolding deleted the fb/bump-snaps branch September 25, 2023 14:33

github-actions bot locked and limited conversation to collaborators Sep 25, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump snaps packages and remove `-flask` versions #20984

Bump snaps packages and remove `-flask` versions #20984

FrederikBolding commented Sep 21, 2023

FrederikBolding commented Sep 21, 2023

metamaskbot commented Sep 21, 2023

Mrtenz Sep 22, 2023

FrederikBolding Sep 22, 2023

metamaskbot commented Sep 22, 2023

codecov bot commented Sep 22, 2023 •

edited

Loading

socket-security bot commented Sep 25, 2023

socket-security bot commented Sep 25, 2023 •

edited

Loading

metamaskbot commented Sep 25, 2023

metamaskbot commented Sep 25, 2023

FrederikBolding commented Sep 25, 2023

metamaskbot commented Sep 25, 2023

Bump snaps packages and remove -flask versions #20984

Bump snaps packages and remove -flask versions #20984

Conversation

FrederikBolding commented Sep 21, 2023

Description

FrederikBolding commented Sep 21, 2023

metamaskbot commented Sep 21, 2023

Mrtenz Sep 22, 2023

Choose a reason for hiding this comment

FrederikBolding Sep 22, 2023

Choose a reason for hiding this comment

metamaskbot commented Sep 22, 2023

codecov bot commented Sep 22, 2023 • edited Loading

Codecov Report

socket-security bot commented Sep 25, 2023

socket-security bot commented Sep 25, 2023 • edited Loading

Next steps

metamaskbot commented Sep 25, 2023

metamaskbot commented Sep 25, 2023

FrederikBolding commented Sep 25, 2023

metamaskbot commented Sep 25, 2023

Bump snaps packages and remove `-flask` versions #20984

Bump snaps packages and remove `-flask` versions #20984

codecov bot commented Sep 22, 2023 •

edited

Loading

socket-security bot commented Sep 25, 2023 •

edited

Loading