-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autodetect tokens link not jumping to section in settings #20978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… brian/token-detection-above-the-fold
… brian/jump-to-autodetect-tokens
bergeron
added
the
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
label
Sep 20, 2023
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #20978 +/- ##
===========================================
- Coverage 68.25% 68.25% -0.00%
===========================================
Files 1006 1006
Lines 40189 40191 +2
Branches 10743 10743
===========================================
Hits 27429 27429
- Misses 12760 12762 +2
☔ View full report in Codecov by Sentry. |
Builds ready [8c2f74d]
Page Load Metrics (1585 ± 67 ms)
Bundle size diffs
|
salimtb
approved these changes
Sep 21, 2023
DDDDDanica
approved these changes
Sep 21, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When clicking the link to enable token autodetection in settings, you land at the top of the settings page instead of jumping to the specific setting.
Also fixes a bug where the import tokens modal did not automatically close when clicking the link. (see video)
Fixed by using the correct settings identifier and calling
onClose()
Manual testing steps
Screenshots/Recordings
Before
bad.mov
After
good.mov
Related issues
Pre-merge author checklist
Pre-merge reviewer checklist