Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autodetect tokens link not jumping to section in settings #20978

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Sep 20, 2023

Description

When clicking the link to enable token autodetection in settings, you land at the top of the settings page instead of jumping to the specific setting.

Also fixes a bug where the import tokens modal did not automatically close when clicking the link. (see video)

Fixed by using the correct settings identifier and calling onClose()

Manual testing steps

  1. Open a metamask wallet
  2. Turn token autodetection off in settings
  3. Click import tokens
  4. Click the button to enable token autodetection in settings
  5. Verify whether you land at the specific token autodetection setting

Screenshots/Recordings

Before

bad.mov

After

good.mov

Related issues

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Sep 20, 2023
@bergeron bergeron requested a review from a team as a code owner September 20, 2023 22:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9f7ccfc) 68.25% compared to head (8c2f74d) 68.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20978      +/-   ##
===========================================
- Coverage    68.25%   68.25%   -0.00%     
===========================================
  Files         1006     1006              
  Lines        40189    40191       +2     
  Branches     10743    10743              
===========================================
  Hits         27429    27429              
- Misses       12760    12762       +2     
Files Changed Coverage Δ
...tichain/import-tokens-modal/import-tokens-modal.js 66.10% <0.00%> (-0.56%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [8c2f74d]
Page Load Metrics (1585 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint118175139168
domContentLoaded14442017158213565
load14442033158514067
domInteractive14442017158213565
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -28 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron merged commit 31262a0 into develop Sep 21, 2023
10 checks passed
@bergeron bergeron deleted the brian/jump-to-autodetect-tokens branch September 21, 2023 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants