-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(20853): improve the logic to handle fetch #20977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
DDDDDanica
force-pushed
the
fix/20853-403
branch
from
September 20, 2023 22:29
6966f72
to
265270b
Compare
DDDDDanica
force-pushed
the
fix/20853-403
branch
from
September 20, 2023 22:47
265270b
to
6866f79
Compare
Builds ready [2fc4b50]
Page Load Metrics (1626 ± 43 ms)
Bundle size diffs
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20977 +/- ##
===========================================
+ Coverage 68.42% 68.42% +0.01%
===========================================
Files 1006 1006
Lines 40209 40213 +4
Branches 10752 10754 +2
===========================================
+ Hits 27510 27515 +5
+ Misses 12699 12698 -1
☔ View full report in Codecov by Sentry. |
gauthierpetetin
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 21, 2023
albertolive
previously approved these changes
Sep 22, 2023
pedronfigueiredo
approved these changes
Sep 22, 2023
Builds ready [7c770a3]
Page Load Metrics (1524 ± 44 ms)
Bundle size diffs
|
vthomas13
approved these changes
Sep 22, 2023
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 22, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #20853
For sentry error:
https://metamask.sentry.io/issues/3404840685/events/a304e0a6b9784a7780254191cdb0dc59/?project=273505
In UI level, the error should be captured and contribute to a state that renders the link. Therefore, we do not need extra UI element to deal with the error. When the error shows up, we want to capture in the
catch
and set that state again just in case.Manual testing steps
{shouldShowNetworkInfo && <NewNetworkInfo />}
to<NewNetworkInfo />
inui/pages/routes/routes.component.js
for testing purpose0x
Screenshots/Recordings
Before
[screenshot]
After
network-info.mov
Related issues
_Fixes #20853
Pre-merge author checklist
Pre-merge reviewer checklist