Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solana derivation paths for snaps #20968

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

FrederikBolding
Copy link
Member

Description

Fixes hardcoded Solana derivation paths used by snaps.

Fixes https://github.com/MetaMask/MetaMask-planning/issues/1312

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Sep 20, 2023
@FrederikBolding FrederikBolding requested a review from a team as a code owner September 20, 2023 08:01
@metamaskbot
Copy link
Collaborator

Builds ready [cdf0c38]
Page Load Metrics (2487 ± 341 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint11754728313163
domContentLoaded140833972487709341
load140833972487709341
domInteractive140833972487709341
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 64 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a3a99aa) 68.25% compared to head (cdf0c38) 68.25%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #20968   +/-   ##
========================================
  Coverage    68.25%   68.25%           
========================================
  Files         1006     1006           
  Lines        40184    40184           
  Branches     10742    10742           
========================================
  Hits         27424    27424           
  Misses       12760    12760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit df327a4 into develop Sep 20, 2023
11 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-solana-dpaths branch September 20, 2023 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 20, 2023
@danjm danjm added release-11.2.0 Issue or pull request that will be included in release 11.2.0 release-blocker This bug is blocking the next release and removed release-11.3.0 Issue or pull request that will be included in release 11.3.0 labels Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.2.0 Issue or pull request that will be included in release 11.2.0 release-blocker This bug is blocking the next release team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants