Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramps buy/sell button What's New #20965

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Ramps buy/sell button What's New #20965

merged 4 commits into from
Sep 26, 2023

Conversation

kevinghim
Copy link
Contributor

Description

The Ramps team is introducing an off-ramps functionality within the Portfolio. This What's New was created to make users aware of this feature. Now the Buy button will be changed to a Buy & Sell button.

Manual testing steps

  1. Install a new MetaMask or update it to the latest build
  2. This What's New item should appear on the second position after the Snaps announcement. If you've already seen the Snaps announcement, it'll be the first item you see.
  3. CTA should click through to https://portfolio.metamask.io/sell/build-quote

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

3 What's New items:

  • Introducing new and refreshed Swaps!
  • Looking for your account details or block explorer URL?
  • Introducing MetaMask Snaps

After

2 What's New items:

  • Introducing MetaMask Snaps
  • Ramps buy & sell button

Screenshot 2023-09-19 at 6 10 02 PM

Related issues

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Sep 19, 2023
@kevinghim kevinghim requested a review from a team as a code owner September 19, 2023 22:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kevinghim kevinghim self-assigned this Sep 21, 2023
Copy link
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Congrats on your first PR!

ui/selectors/selectors.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (315c043) 68.34% compared to head (9e74fd5) 68.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20965      +/-   ##
===========================================
- Coverage    68.34%   68.33%   -0.00%     
===========================================
  Files         1007     1007              
  Lines        40254    40260       +6     
  Branches     10761    10762       +1     
===========================================
+ Hits         27508    27511       +3     
- Misses       12746    12749       +3     
Files Changed Coverage Δ
.../components/app/whats-new-popup/whats-new-popup.js 42.07% <0.00%> (-0.89%) ⬇️
ui/selectors/selectors.js 86.74% <ø> (-0.02%) ⬇️
shared/notifications/index.js 56.36% <66.67%> (+3.42%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [9e74fd5]
Page Load Metrics (1598 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint871661112010
domContentLoaded741611062211
load14211790159810550
domInteractive741611062211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 249 Bytes (0.00%)
  • common: 888 Bytes (0.02%)

Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@darkwing darkwing merged commit 7f6ea72 into develop Sep 26, 2023
9 checks passed
@darkwing darkwing deleted the ramps-sell-whatsnew branch September 26, 2023 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants