-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ramps buy/sell button What's New #20965
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! Congrats on your first PR!
5111467
to
c4e388e
Compare
c4e388e
to
9e74fd5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20965 +/- ##
===========================================
- Coverage 68.34% 68.33% -0.00%
===========================================
Files 1007 1007
Lines 40254 40260 +6
Branches 10761 10762 +1
===========================================
+ Hits 27508 27511 +3
- Misses 12746 12749 +3
☔ View full report in Codecov by Sentry. |
Builds ready [9e74fd5]
Page Load Metrics (1598 ± 50 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
The Ramps team is introducing an off-ramps functionality within the Portfolio. This What's New was created to make users aware of this feature. Now the Buy button will be changed to a Buy & Sell button.
Manual testing steps
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Before
3 What's New items:
After
2 What's New items:
Related issues
Pre-merge author checklist
Pre-merge reviewer checklist