You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Go to https://metamask.github.io/snap-simple-keyring/0.2.2/ 2. Proceed to install snap using Flask 3. Hover tooltip icon. It should show the permission description 4. Install snap 5. Go to snap settings 6. See details of the manageAccounts permission. It should show the permission description
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
In case it's not yet "ready for review", I've set it to "draft".
In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
❗ Current head 3c39a78 differs from pull request most recent head 80e8de8. Consider uploading reports for the commit 80e8de8 to get more accurate results
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing tooltip description to the
manageAccounts
permission.Snap permissions source.Tooltip updated to:
Allow this Snap to add or remove Ethereum accounts, then transact and sign with these accounts.
Review comment from @coreyjanssen
Manual testing steps
1. Go to https://metamask.github.io/snap-simple-keyring/0.2.2/
2. Proceed to install snap using Flask
3. Hover tooltip icon. It should show the permission description
4. Install snap
5. Go to snap settings
6. See details of the manageAccounts permission. It should show the permission description
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Related issues
Fixes https://github.com/MetaMask/accounts-planning/issues/52
Pre-merge author checklist
Pre-merge reviewer checklist