-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds e2e json rpc method tests. #20963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #20963 +/- ##
========================================
Coverage 68.40% 68.40%
========================================
Files 1008 1008
Lines 40300 40300
Branches 10778 10778
========================================
Hits 27565 27565
Misses 12735 12735 ☔ View full report in Codecov by Sentry. |
Builds ready [6fc6aaa]
Page Load Metrics (1561 ± 37 ms)
Bundle size diffs
|
seaona
reviewed
Sep 20, 2023
seaona
reviewed
Sep 20, 2023
seaona
reviewed
Sep 20, 2023
seaona
reviewed
Sep 20, 2023
seaona
reviewed
Sep 20, 2023
jiexi
reviewed
Sep 20, 2023
tmashuang
force-pushed
the
e2e-json-rpc-method-tests
branch
from
September 22, 2023 04:06
40aa454
to
fc91d0c
Compare
Builds ready [fc91d0c]
Page Load Metrics (1859 ± 54 ms)
Bundle size diffs
|
seaona
approved these changes
Sep 26, 2023
Builds ready [89ea4d3]
Page Load Metrics (1022 ± 365 ms)
Bundle size diffs
|
jiexi
approved these changes
Sep 27, 2023
Builds ready [9d7d0b2]
Page Load Metrics (1037 ± 362 ms)
Bundle size diffs
|
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-testSuite
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-wallet-api-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
1. What is the reason for the change?
2. What is the improvement/solution?
Adds e2e json rpc method tests for
eth_newBlockFilter
,eth_accounts
,eth_gasPrice
, andeth_estimateGas
.Manual testing steps
1. Step1:
2. Step2:
3. ...
yarn && yarn build:test
yarn test:e2e:chrome:rpc
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Before
[screenshot]
After
[screenshot]
Related issues
Fixes #???
Pre-merge author checklist
Pre-merge reviewer checklist