Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds e2e json rpc method tests. #20963

Merged
merged 9 commits into from
Sep 28, 2023
Merged

Adds e2e json rpc method tests. #20963

merged 9 commits into from
Sep 28, 2023

Conversation

tmashuang
Copy link
Contributor

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
1. What is the reason for the change?
2. What is the improvement/solution?

Adds e2e json rpc method tests for eth_newBlockFilter, eth_accounts, eth_gasPrice, and eth_estimateGas.

Manual testing steps

1. Step1:
2. Step2:
3. ...

  1. Pull down branch
  2. yarn && yarn build:test
  3. yarn test:e2e:chrome:rpc
  4. Tests should not fail.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c2bda35) 68.40% compared to head (9d7d0b2) 68.40%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #20963   +/-   ##
========================================
  Coverage    68.40%   68.40%           
========================================
  Files         1008     1008           
  Lines        40300    40300           
  Branches     10778    10778           
========================================
  Hits         27565    27565           
  Misses       12735    12735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [6fc6aaa]
Page Load Metrics (1561 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint114180139178
domContentLoaded1432172915607737
load1432173015617737
domInteractive1432172915607737
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@tmashuang tmashuang force-pushed the e2e-json-rpc-method-tests branch from 40aa454 to fc91d0c Compare September 22, 2023 04:06
@metamaskbot
Copy link
Collaborator

Builds ready [fc91d0c]
Page Load Metrics (1859 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1282251652411
domContentLoaded16872076185911354
load16872076185911354
domInteractive16872076185911354
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona self-requested a review September 26, 2023 12:11
@metamaskbot
Copy link
Collaborator

Builds ready [89ea4d3]
Page Load Metrics (1022 ± 365 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861139784
domContentLoaded6713291168
load8017301022761365
domInteractive6713291168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [9d7d0b2]
Page Load Metrics (1037 ± 362 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90146117178
domContentLoaded74150108199
load8918181037754362
domInteractive74150108199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@tmashuang tmashuang merged commit 9dd98a9 into develop Sep 28, 2023
9 checks passed
@tmashuang tmashuang deleted the e2e-json-rpc-method-tests branch September 28, 2023 02:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testSuite release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants