fix: display msg if tokenId already exists #20940

sahar-fehri · 2023-09-18T20:17:19Z

Explanation

This PR adds displaying an error msg when the nft has been already imported.
This avoids seeing the same nft twice when the user first imports tokenId(decimal value) then imports it again (hex value).

Fixes #MMASSETS-27

Screenshots/Screencaps

Before

Github issue : #18957

After

1- Mint and import nft with id 577

2- Try importing Nft again with id 577

3- Try importing Nft again with hex value: 0x241

Manual Testing Steps

Pre-merge author checklist

I've clearly explained:
- [x ] What problem this PR is solving
- [ x] How this problem was solved
- [x ] How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

github-actions · 2023-09-18T20:17:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

darkwing

Just some small nits. This is awesome!

ui/helpers/utils/util.js

metamaskbot · 2023-09-20T07:59:58Z

Builds ready [4642172]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1631 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	122	183	145	19	9
		domContentLoaded	1417	1764	1630	103	50
		load	1417	1764	1631	104	50
		domInteractive	1417	1764	1630	103	50

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 413 Bytes (0.00%)
common: 684 Bytes (0.01%)

codecov · 2023-09-20T08:00:07Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (77b3b80) 68.46% compared to head (38e62ae) 68.48%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #20940      +/-   ##
===========================================
+ Coverage    68.46%   68.48%   +0.02%     
===========================================
  Files         1012     1012              
  Lines        40449    40472      +23     
  Branches     10790    10799       +9     
===========================================
+ Hits         27693    27715      +22     
- Misses       12756    12757       +1

Files	Coverage Δ
ui/helpers/utils/util.js	`84.87% <100.00%> (+0.76%)`	⬆️
.../multichain/import-nfts-modal/import-nfts-modal.js	`94.37% <90.91%> (-0.72%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danjm

LGTM

danjm

hold on, just noticed something... comment incoming

ui/helpers/utils/util.js

metamaskbot · 2023-09-26T15:40:08Z

Builds ready [6304f83]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1059 ± 339 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	125	99	13	6
		domContentLoaded	74	121	92	13	6
		load	85	1832	1059	705	339
		domInteractive	74	121	92	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 413 Bytes (0.00%)
common: 649 Bytes (0.01%)

metamaskbot · 2023-09-26T17:33:24Z

Builds ready [825b36c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (548 ± 334 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	148	101	14	7
		domContentLoaded	72	120	91	13	6
		load	83	1750	548	696	334
		domInteractive	72	120	91	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 413 Bytes (0.00%)
common: 649 Bytes (0.01%)

metamaskbot · 2023-09-28T14:40:15Z

Builds ready [2132d39]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (842 ± 386 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	154	117	18	9
		domContentLoaded	76	130	107	15	7
		load	87	1870	842	804	386
		domInteractive	76	130	107	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 413 Bytes (0.00%)
common: 649 Bytes (0.01%)

metamaskbot · 2023-09-29T08:40:29Z

Builds ready [9229826]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (914 ± 356 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	120	99	11	5
		domContentLoaded	71	120	93	13	6
		load	86	1726	914	741	356
		domInteractive	71	119	93	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 413 Bytes (0.00%)
common: 649 Bytes (0.01%)

metamaskbot · 2023-09-29T11:09:49Z

Builds ready [87e4c87]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (913 ± 395 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	83	158	104	18	9
		domContentLoaded	67	142	95	21	10
		load	78	2044	913	824	395
		domInteractive	67	142	95	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 413 Bytes (0.00%)
common: 649 Bytes (0.01%)

metamaskbot · 2023-09-29T15:58:48Z

Builds ready [38e62ae]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (529 ± 321 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	122	96	13	6
		domContentLoaded	64	114	86	15	7
		load	76	1696	529	669	321
		domInteractive	64	114	86	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 413 Bytes (0.00%)
common: 649 Bytes (0.01%)

sahar-fehri requested a review from a team as a code owner September 18, 2023 20:17

sahar-fehri force-pushed the fix/MMASSETS-27 branch from 5a05e80 to 469b844 Compare September 18, 2023 20:21

sahar-fehri added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Sep 19, 2023

sahar-fehri force-pushed the fix/MMASSETS-27 branch 3 times, most recently from 945161e to 724c1d7 Compare September 19, 2023 11:52

sahar-fehri requested review from a team as code owners September 19, 2023 13:41

sahar-fehri force-pushed the fix/MMASSETS-27 branch from 3424791 to f65b2a9 Compare September 19, 2023 13:44

darkwing requested changes Sep 19, 2023

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

bergeron reviewed Sep 19, 2023

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

sahar-fehri force-pushed the fix/MMASSETS-27 branch from e95ca5c to d2c6d07 Compare September 19, 2023 16:08

sahar-fehri requested a review from darkwing September 19, 2023 16:22

bergeron reviewed Sep 19, 2023

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

bergeron reviewed Sep 19, 2023

View reviewed changes

ui/helpers/utils/util.js Outdated Show resolved Hide resolved

bergeron previously approved these changes Sep 19, 2023

View reviewed changes

sahar-fehri dismissed bergeron’s stale review via 8a575b3 September 19, 2023 16:57

sahar-fehri force-pushed the fix/MMASSETS-27 branch 3 times, most recently from bd90602 to 4642172 Compare September 19, 2023 22:50

pedronfigueiredo previously approved these changes Sep 20, 2023

View reviewed changes

danjm approved these changes Sep 21, 2023

View reviewed changes

danjm requested changes Sep 21, 2023

View reviewed changes

danjm reviewed Sep 21, 2023

View reviewed changes

ui/helpers/utils/util.js Show resolved Hide resolved

sahar-fehri dismissed pedronfigueiredo’s stale review via 3b088dd September 25, 2023 12:47

sahar-fehri force-pushed the fix/MMASSETS-27 branch 2 times, most recently from 4c52200 to 3b96e19 Compare September 25, 2023 12:49

sahar-fehri force-pushed the fix/MMASSETS-27 branch from 6304f83 to 825b36c Compare September 26, 2023 16:50

sahar-fehri force-pushed the fix/MMASSETS-27 branch 3 times, most recently from 56bbd44 to 2132d39 Compare September 28, 2023 14:01

sahar-fehri requested review from danjm, bergeron and pedronfigueiredo September 28, 2023 15:28

brad-decker previously approved these changes Sep 28, 2023

View reviewed changes

danjm previously approved these changes Sep 28, 2023

View reviewed changes

sahar-fehri force-pushed the fix/MMASSETS-27 branch from 2132d39 to 9229826 Compare September 29, 2023 07:57

pedronfigueiredo previously approved these changes Sep 29, 2023

View reviewed changes

sahar-fehri dismissed stale reviews from pedronfigueiredo, danjm, and brad-decker via 6a6074d September 29, 2023 09:56

sahar-fehri force-pushed the fix/MMASSETS-27 branch 2 times, most recently from 6a6074d to 87e4c87 Compare September 29, 2023 10:29

darkwing approved these changes Sep 29, 2023

View reviewed changes

fix: display msg if tokenId already exists

38e62ae

sahar-fehri force-pushed the fix/MMASSETS-27 branch from 87e4c87 to 38e62ae Compare September 29, 2023 14:59

bergeron approved these changes Sep 29, 2023

View reviewed changes

sahar-fehri merged commit 707b2f4 into develop Sep 29, 2023
9 checks passed

sahar-fehri deleted the fix/MMASSETS-27 branch September 29, 2023 15:59

github-actions bot locked and limited conversation to collaborators Sep 29, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: display msg if tokenId already exists #20940

fix: display msg if tokenId already exists #20940

sahar-fehri commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

darkwing left a comment

metamaskbot commented Sep 20, 2023

codecov bot commented Sep 20, 2023 •

edited

Loading

danjm left a comment

danjm left a comment

metamaskbot commented Sep 26, 2023

metamaskbot commented Sep 26, 2023

metamaskbot commented Sep 28, 2023

metamaskbot commented Sep 29, 2023

metamaskbot commented Sep 29, 2023

metamaskbot commented Sep 29, 2023

fix: display msg if tokenId already exists #20940

fix: display msg if tokenId already exists #20940

Conversation

sahar-fehri commented Sep 18, 2023

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 18, 2023

darkwing left a comment

Choose a reason for hiding this comment

metamaskbot commented Sep 20, 2023

codecov bot commented Sep 20, 2023 • edited Loading

Codecov Report

danjm left a comment

Choose a reason for hiding this comment

danjm left a comment

Choose a reason for hiding this comment

metamaskbot commented Sep 26, 2023

metamaskbot commented Sep 26, 2023

metamaskbot commented Sep 28, 2023

metamaskbot commented Sep 29, 2023

metamaskbot commented Sep 29, 2023

metamaskbot commented Sep 29, 2023

codecov bot commented Sep 20, 2023 •

edited

Loading