Feat/add mm e2e mmi build #20931
Merged
Feat/add mm e2e mmi build #20931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
racitores
force-pushed
the
feat/add-mm-e2e-mmi-build
branch
from
aa1d782 to
f9f4ae0
Compare
Builds ready [aa1d782]
Page Load Metrics (1877 ± 96 ms)
Bundle size diffs
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #20931 +/- ##
========================================
Coverage 68.36% 68.36%
========================================
Files 1006 1006
Lines 40262 40262
Branches 10763 10763
========================================
Hits 27522 27522
Misses 12740 12740 ☔ View full report in Codecov by Sentry. |
racitores
requested review from
kumavis,
brad-decker and
a team
as code owners
Builds ready [f9f4ae0]
Page Load Metrics (1564 ± 35 ms)
Bundle size diffs
|
racitores
force-pushed
the
feat/add-mm-e2e-mmi-build
branch
from
f9f4ae0 to
b46600b
Compare
Builds ready [b46600b]
Page Load Metrics (1551 ± 78 ms)
Bundle size diffs
|
brad-decker
suggested changes
Sep 20, 2023
There was a problem hiding this comment.
@PeterYinusa you should probably review this and see if we should include some way of documenting the @no-mmi flag in our E2E documents. Blocking for review but overall the code looks good for me.
brad-decker
reviewed
Sep 20, 2023
test/e2e/run-e2e-test.js
Outdated
Comment on lines
125
to
131
| if (mmi) { | ||
| extraArgs.push('-g', '@no-mmi', '-i'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you add inline documentation here for what these flags do (grep/invert) and explain the @no-mmi tag on some of the tests
Thanks for the heads up @brad-decker, this seems in line with the approach discussed with @racitores. |
PeterYinusa
previously approved these changes
Sep 21, 2023
racitores
dismissed stale reviews from PeterYinusa and zone-live
via
43fd3db
racitores
force-pushed
the
feat/add-mm-e2e-mmi-build
branch
from
b46600b to
43fd3db
Compare
zone-live
approved these changes
Sep 22, 2023
Builds ready [43fd3db]
Page Load Metrics (1526 ± 51 ms)
Bundle size diffs
|
Builds ready [5255fdf]
Page Load Metrics (1513 ± 46 ms)
Bundle size diffs
|
brad-decker
approved these changes
Sep 22, 2023
metamaskbot
added
the
release-11.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently MMI extension is assuming that all general/core MM extension features should work under MMI but this is not been tested in the pipeline.
This PR adds Metamask e2e tests run in the circle ci pipeline for a MMI build generated extension. There are a set failing tests marked as
@no-mmiso that when running the tests withyarn test:e2e:chrome:mmiwill doSELENIUM_BROWSER=chrome node test/e2e/run-all.js --mmipassing --mmi as param.This is a first step to improve MMI test coverage and regression. Next steps will be reviewed and updated tests if required
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.