Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ModalContent to use TS version of Box #20922

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

dhruvv173
Copy link
Contributor

Explanation

Screenshots/Screencaps

Before

before.mp4

After

after.mp4

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner September 16, 2023 09:17
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9f7ccfc) 68.25% compared to head (6994aac) 68.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20922      +/-   ##
===========================================
- Coverage    68.25%   68.25%   -0.00%     
===========================================
  Files         1006     1006              
  Lines        40189    40189              
  Branches     10743    10743              
===========================================
- Hits         27429    27427       -2     
- Misses       12760    12762       +2     
Files Changed Coverage Δ
.../component-library/modal-content/modal-content.tsx 96.15% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Sep 20, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @dhruvv173 🙏

@darkwing darkwing merged commit 492a949 into MetaMask:develop Sep 22, 2023
9 checks passed
@darkwing
Copy link
Contributor

Thank you @dhruvv173 !

@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
@dhruvv173 dhruvv173 deleted the fix/20160 branch September 22, 2023 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ModalContent to use TS Box version
3 participants