Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the Snap npm link now leads to a specific version of the npm package #20897

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Sep 15, 2023

These two version links used to say a version (0.1.4 in the screenshots), but then link to the newest version on npm.
Now they link to https://www.npmjs.com/package/@metamask/snap-simple-keyring-snap/v/0.1.4

(also updated the deprecated Design System components in snap-authorship-expanded.js)

Screenshots

image
image

Manual Testing Steps

  1. Install the old version of a Snap
  2. Check the link as you're installing (first screenshot)
  3. Check the link after you've installed (second screenshot)

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@HowardBraham HowardBraham requested a review from a team as a code owner September 15, 2023 06:18
@HowardBraham HowardBraham self-assigned this Sep 15, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f690d9a) 68.35% compared to head (9c47a2a) 68.35%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #20897   +/-   ##
========================================
  Coverage    68.35%   68.35%           
========================================
  Files         1007     1007           
  Lines        40261    40263    +2     
  Branches     10766    10768    +2     
========================================
+ Hits         27519    27521    +2     
  Misses       12742    12742           
Files Changed Coverage Δ
ui/selectors/selectors.js 86.76% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e5aecf1]
Page Load Metrics (1794 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1232531563014
domContentLoaded15472098179416278
load15472098179416278
domInteractive15472098179416278
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -136 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham force-pushed the fix/versioned-snap-npm-page branch from e5aecf1 to 02e7be3 Compare September 21, 2023 05:33
@metamaskbot
Copy link
Collaborator

Builds ready [02e7be3]
Page Load Metrics (1438 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint115166126136
domContentLoaded1353158214375928
load1353158214385928
domInteractive1353158214375928
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -136 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Mrtenz
Mrtenz previously approved these changes Sep 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [9c47a2a]
Page Load Metrics (1632 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint841621052110
domContentLoaded72158982210
load14761970163213364
domInteractive72158982210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -70 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2023
@HowardBraham HowardBraham merged commit 98066f7 into develop Sep 25, 2023
10 checks passed
@HowardBraham HowardBraham deleted the fix/versioned-snap-npm-page branch September 25, 2023 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants