-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the Snap npm link now leads to a specific version of the npm package #20897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20897 +/- ##
========================================
Coverage 68.35% 68.35%
========================================
Files 1007 1007
Lines 40261 40263 +2
Branches 10766 10768 +2
========================================
+ Hits 27519 27521 +2
Misses 12742 12742
☔ View full report in Codecov by Sentry. |
Builds ready [e5aecf1]
Page Load Metrics (1794 ± 78 ms)
Bundle size diffs
|
HowardBraham
force-pushed
the
fix/versioned-snap-npm-page
branch
from
September 21, 2023 05:33
e5aecf1
to
02e7be3
Compare
Builds ready [02e7be3]
Page Load Metrics (1438 ± 28 ms)
Bundle size diffs
|
Mrtenz
previously approved these changes
Sep 22, 2023
owencraston
reviewed
Sep 22, 2023
ui/components/app/snaps/snap-authorship-header/snap-authorship-header.js
Outdated
Show resolved
Hide resolved
HowardBraham
force-pushed
the
fix/versioned-snap-npm-page
branch
from
September 22, 2023 22:31
02e7be3
to
9c47a2a
Compare
owencraston
approved these changes
Sep 22, 2023
Builds ready [9c47a2a]
Page Load Metrics (1632 ± 64 ms)
Bundle size diffs
|
HowardBraham
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 25, 2023
Mrtenz
approved these changes
Sep 25, 2023
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 25, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two version links used to say a version (0.1.4 in the screenshots), but then link to the newest version on npm.
Now they link to https://www.npmjs.com/package/@metamask/snap-simple-keyring-snap/v/0.1.4
(also updated the deprecated Design System components in
snap-authorship-expanded.js
)Screenshots
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.